Fix Go e2e tests not running in CI #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ./... to go test commands to include tests in subdirectories like go/e2e/
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical issue where Go e2e tests in the go/e2e/ directory were not being executed during CI runs. The test script was only looking for tests in the root go/ directory.
Changes:
- Added
./...package pattern to allgo testcommands to recursively discover and run tests in subdirectories
Comments suppressed due to low confidence (4)
go/test.sh:55
- The package pattern
./...should be placed after all flags for better readability and consistency with Go conventions. While the current syntax works, the idiomatic format isgo test -v -run TestIntegration -timeout 60s ./...where all flags come before the package specification.
This issue also appears in the following locations of the same file:
- line 59
- line 47
- line 51
go/test.sh:59
- The package pattern
./...should be placed after all flags for better readability and consistency with Go conventions. While the current syntax works, the idiomatic format isgo test -v -run TestHelpers -timeout 90s ./...where all flags come before the package specification.
go/test.sh:47 - The package pattern
./...should be placed after all flags for better readability and consistency with Go conventions. While the current syntax works, the idiomatic format isgo test -v -run TestClient -timeout 60s ./...where all flags come before the package specification.
go/test.sh:51 - The package pattern
./...should be placed after all flags for better readability and consistency with Go conventions. While the current syntax works, the idiomatic format isgo test -v -run TestSession -timeout 60s ./...where all flags come before the package specification.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
devm33
approved these changes
Jan 19, 2026
This was referenced Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test.sh script was running
go test -run TestXwithout./..., so it only looked for tests in the rootgo/directory and missed all tests ingo/e2e/.This adds
./...to eachgo testcommand so tests in subdirectories are discovered and executed.