Add session event subscription tests for all SDKs #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename .NET test from Should_SessionEvt_Subscribed to Should_Receive_Session_Events - Add equivalent tests for Node.js, Python, and Go SDKs - Add shared snapshot file for test replay
- Change prompt to 'What is 100+200?' - Assert assistant response contains '300' - Regenerate snapshot file
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive test coverage for session event subscription functionality across all SDK languages (Node.js, Python, Go, and .NET). The tests verify that SDKs properly receive and handle user.message, assistant.message, and session.idle events.
Changes:
- Renamed .NET test from
Should_SessionEvt_SubscribedtoShould_Receive_Session_Eventsfor clarity - Added session event subscription tests for Node.js, Python, and Go SDKs
- Added test snapshot file for replay testing with a simple arithmetic question (100+200=300)
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/snapshots/session/should_receive_session_events.yaml | Snapshot file for test replay with 100+200 arithmetic test case |
| python/e2e/test_session.py | Added Python async test with event collection and idle event handling |
| nodejs/test/e2e/session.test.ts | Added Node.js test with Promise-based event handling and timeout |
| go/e2e/session_test.go | Added Go test with channel-based event handling and proper synchronization |
| dotnet/test/SessionTests.cs | Renamed test method and updated prompt to match other SDKs; added response verification |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
friggeri
approved these changes
Jan 15, 2026
jmoseley
pushed a commit
that referenced
this pull request
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for the session event subscription feature across all SDK languages, following up on PR #11.
Changes
Test Coverage
All tests verify user.message, assistant.message, and session.idle events are received, plus assert the response contains 300.
Closes #12