8000 Merge main into releases/v3 by github-actions[bot] · Pull Request #2746 · github/codeql-action · GitHub
[go: up one dir, main page]
Skip to content

Merge main into releases/v3 #2746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 29, 2025
Merged

Merge main into releases/v3 #2746

merged 9 commits into from
Jan 29, 2025

Conversation

github-actions[bot]
Copy link
Contributor
@github-actions github-actions bot commented Jan 29, 2025 •
edited by igfoo
Loading

Merging a91a3f7 into releases/v3.

Conductor for this PR is @igfoo.

Contains the following pull requests:

Please do the following:

  • Ensure the CHANGELOG displays the correct version and date.
  • Ensure the CHANGELOG includes all relevant, user-facing changes since the last release.
  • Check that there are not any unexpected commits being merged into the releases/v3 branch.
  • Ensure the docs team is aware of any documentation changes that need to be released.
  • Mark the PR as ready for review to trigger the full set of PR checks.
  • Approve and merge this PR. Make sure Create a merge commit is selected rather than Squash and merge or Rebase and merge.
  • Merge the mergeback PR that will automatically be created once this PR is merged.
  • Merge all backport PRs to older release branches, that will automatically be created once this PR is merged.

@igfoo igfoo marked this pull request as ready for review January 29, 2025 18:05
@Copilot Copilot AI review requested due to automatic review settings January 29, 2025 18:05
@igfoo igfoo requested a review from a team as a code owner January 29, 2025 18:05
Copilot
Copilot AI reviewed Jan 29, 2025
View reviewed changes
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/init-action.ts:548

  • Add a test verifying that this environment variable is only set for CodeQL CLI v2.20.3 but not for v2.20.4 or above.
core.exportVariable(kotlinLimitVar, "2.1.20");

lib/init-action.js:323

  • Add a test verifying that this environment variable is only set for CodeQL CLI v2.20.3 but not for v2.20.4 or above.
core.exportVariable(kotlinLimitVar, "2.1.20");

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

rvermeulen
rvermeulen approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor
@rvermeulen rvermeulen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the quick workaround!

@igfoo igfoo merged commit dd74661 into releases/v3 Jan 29, 2025
266 checks passed
@igfoo igfoo deleted the update-v3.28.8-a91a3f767 branch January 29, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@rvermeulen rvermeulen rvermeulen approved these changes

@henrymercer henrymercer henrymercer approved these changes

Assignees

@igfoo igfoo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rvermeulen @henrymercer @igfoo @marcogario
0