8000 Remove config parsing logic that is now implemented in the CLI by henrymercer · Pull Request #2062 · github/codeql-action · GitHub
[go: up one dir, main page]
Skip to content

Remove config parsing logic that is now implemented in the CLI #2062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 5, 2024
Merged

Remove config parsing logic that is now implemented in the CLI #2062

merged 10 commits into from
Jan 5, 2024

Conversation

henrymercer
Copy link
Contributor

In CodeQL CLI v2.11.6, we finished implementing key parts of parsing the code scanning configuration within the CLI. This enabled this functionality to be used by folks running code scanning using a third-party CI system.

However due to the need to support earlier versions of the CLI that do not support config parsing, we have needed to duplicate config parsing code between the Action and the CLI.

Now that CodeQL CLI v2.11.5 and earlier have been deprecated, we can remove this legacy config parsing code from the Action.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer mentioned this pull request Jan 4, 2024
Closed
3 tasks
@henrymercer henrymercer marked this pull request as ready for review January 4, 2024 18:06
@henrymercer henrymercer requested a review from a team as a code owner January 4, 2024 18:06
angelapwen
angelapwen previously approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor
@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whew, I think I 👀 d all the changes — looks so much cleaner now! I assume the status report changes will be a follow-up?

@henrymercer
Copy link
Contributor Author

There are two aspects to the status report changes:

  1. Renaming builtin to all — I think this is fairly low priority and can happen as follow up
  2. Removing the custom fields on the server-side — I think it might make sense to keep these around a little longer so we still receive the full telemetry from earlier Actions, so we'll do this as follow up too.

@henrymercer henrymercer requested a review from angelapwen January 5, 2024 16:28
@henrymercer henrymercer merged commit 8516954 into main Jan 5, 2024
@henrymercer henrymercer deleted the henrymercer/remove-action-config-parsing branch January 5, 2024 18:49
@github-actions github-actions bot mentioned this pull request Jan 8, 2024
Merged
8 tasks
This was referenced Jan 8, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@angelapwen angelapwen angelapwen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@henrymercer @angelapwen
0