8000 Validate workflow within new log group by henrymercer · Pull Request #1970 · github/codeql-action · GitHub
[go: up one dir, main page]
Skip to content

Validate workflow within new log group #1970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 27, 2023
Merged

Validate workflow within new log group #1970

merged 2 commits into from
Oct 27, 2023

Conversation

henrymercer
Copy link
Contributor

This cleans up the logs for init.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer
Validate workflow within new log group
06662f5 
This cleans up the logs for `init`.
@henrymercer henrymercer requested a review from a team as a code owner October 26, 2023 10:17
angelapwen
angelapwen previously approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor
@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@angelapwen
Copy link
Contributor
angelapwen commented Oct 26, 2023 •
edited
Loading

Although this seems to come out empty — I wonder if that's confusing to users? Does it need to run in debug mode to actually show something in the group?

Screenshot 2023-10-26 at 10 18 38 AM

@henrymercer
Copy link
Contributor Author

Although this seems to come out empty — I wonder if that's confusing to users? Does it need to run in debug mode to actually show something in the group?

Our test workflows are a little unusual since they don't have the typical languages matrix configuration. Therefore we're not seeing the CodeQL CLI logs for codeql resolve languages, since that validation isn't being called.

I think the best way to address this is to add a log that no issues were detected.

angelapwen
angelapwen approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor
@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@henrymercer henrymercer enabled auto-merge October 26, 2023 19:01
@henrymercer henrymercer disabled auto-merge October 26, 2023 19:13
@henrymercer henrymercer merged commit 2d5ffa7 into main Oct 27, 2023
@henrymercer henrymercer deleted the henrymercer/clean-up-init-logs branch October 27, 2023 08:32
@github-actions github-actions bot mentioned this pull request Oct 27, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@angelapwen angelapwen angelapwen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@henrymercer @angelapwen
0