8000 Fix the `bundleVersion` field set by the automated bundle update PR by henrymercer · Pull Request #1652 · github/codeql-action · GitHub
[go: up one dir, main page]
Skip to content

Fix the bundleVersion field set by the automated bundle update PR #1652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Fix the bundleVersion field set by the automated bundle update PR #1652

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c2f282
Fix bundle version
henrymercer Apr 18, 2023
55a2e70
Autoformat `index.ts`
henrymercer Apr 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix bundle version 
It's the whole tag, we don't want to remove the `codeql-bundle-` prefix.
  • Loading branch information
@henrymercer
henrymercer committed Apr 18, 2023
commit 1c2f282107790c08e265e1e92475e3df734296cb
4 changes: 1 addition & 3 deletions .github/actions/update-bundle/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ interface Defaults {
priorCliVersion: string;
}

const CODEQL_BUNDLE_PREFIX = 'codeql-bundle-';

function getCodeQLCliVersionForRelease(release): string {
// We do not currently tag CodeQL bundles based on the CLI version they contain.
// Instead, we use a marker file `cli-version-<version>.txt` to record the CLI version.
Expand All @@ -37,7 +35,7 @@ function getCodeQLCliVersionForRelease(release): string {

async function getBundleInfoFromRelease(release): Promise<BundleInfo> {
return {
bundleVersion: release.tag_name.substring(CODEQL_BUNDLE_PREFIX.length),
bundleVersion: release.tag_name,
cliVersion: getCodeQLCliVersionForRelease(release)
};
}
Expand Down
0