Add workflow_run_attempt data to status report
#1640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were implicitly converting `any` type to `string`; this does so explicitly.
f749786 to
c432b64
Compare
adityasharad
reviewed
Apr 6, 2023
| workflowRunID = parseInt(workflowRunIDStr, 10); | ||
| } | ||
| const workflowRunAttemptStr = process.env["GITHUB_RUN_ATTEMPT"]; | ||
| let workflowRunAttempt = -1; |
Contributor
There was a problem hiding this comment.
I was going to suggest undefined if not set, but if this is the convention we use for the workflow run ID, stick with it.
adityasharad
previously approved these changes
Apr 10, 2023
adityasharad
approved these changes
Apr 10, 2023
6 tasks
This was referenced Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, we begin reporting the
workflow_run_attemptfield in the status report base, using theGITHUB_RUN_ATTEMPTdefault environment variable (docs)Similar to the
workflow_run_id, we report -1 if the environment variable isn't found for whatever reason.Merge / deployment checklist