Tools telemetry: accurately report when feature flags were inaccessible #1532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
henrymercer
reviewed
Feb 9, 2023
Contributor
There was a problem hiding this comment.
Looks good, just a couple of minor comments.
henrymercer
approved these changes
Feb 10, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge / deployment checklist
Previously, we sent a
falsevalue oftools_feature_flags_validin our status reports when we were actually unable to access our feature flags, for example in cases where the repository does not have the appropriate security permissions to access feature flags. This change should allow us to catch the error where we are unable to access feature flags, and not send thetools_feature_flags_validfield at all to the status report.This will enable us to create a monitor on the
tools_feature_flags_validtelemetry field, as we will always expect it to be 0.