10000 Overlay: Add manual Java overlay annotations & discard predicates by kaspersv · Pull Request #19813 · github/codeql · GitHub
[go: up one dir, main page]
Skip to content

Overlay: Add manual Java overlay annotations & discard predicates #19813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 30, 2025
Merged

Overlay: Add manual Java overlay annotations & discard predicates #19813

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b6e56f2
Java: Add manual overlay annotations
kaspersv Jan 15, 2025
6e92d7e
Java: Add entity discard predicates
kaspersv Jan 9, 2025
0ee6a78
Java: Allow methods with empty bodies for overlay
kaspersv Jan 14, 2025
64f27e2
Java: Add abstraction for discardable locatables
kaspersv Jun 25, 2025
e6ef6a3
Merge branch 'main' into kaspersv/overlay-java-discarding
kaspersv Jun 27, 2025
c7194a4
Overlay: Add missing QLDoc
kaspersv Jun 30, 2025
File filter

Filter by extension

< 8000 /option>
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Java: Add manual overlay annotations
  • Loading branch information
@kaspersv
kaspersv committed Jun 24, 2025
commit b6e56f26c7509a041ce92bdda13db0a09da886e3
1 change: 1 addition & 0 deletions java/ql/src/experimental/Security/CWE/CWE-020/Log4jJndiInjection.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import semmle.code.java.dataflow.ExternalFlow
private import semmle.code.java.security.Sanitizers
import Log4jInjectionFlow::PathGraph

overlay[local?]
deprecated private class ActivateModels extends ActiveExperimentalModels {
ActivateModels() { this = "log4j-injection" }
}
Expand Down
1 change: 1 addition & 0 deletions java/ql/src/experimental/Security/CWE/CWE-036/OpenStream.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import semmle.code.java.dataflow.FlowSources
import semmle.code.java.dataflow.ExternalFlow
import RemoteUrlToOpenStreamFlow::PathGraph

overlay[local?]
deprecated private class ActivateModels extends ActiveExperimentalModels {
ActivateModels() { this = "openstream-called-on-tainted-url" }
}
Expand Down
1 change: 1 addition & 0 deletions java/ql/src/experimental/Security/CWE/CWE-073/FilePathInjection.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import semmle.code.java.security.PathSanitizer
private import semmle.code.java.security.Sanitizers
import InjectFilePathFlow::PathGraph

overlay[local?]
deprecated private class ActivateModels extends ActiveExperimentalModels {
ActivateModels() { this = "file-path-injection" }
}
Expand Down
1 change: 1 addition & 0 deletions java/ql/src/experimental/Security/CWE/CWE-078/ExecTainted.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import semmle.code.java.security.CommandLineQuery
import InputToArgumentToExecFlow::PathGraph
private import semmle.code.java.dataflow.ExternalFlow

overlay[local?]
deprecated private class ActivateModels extends ActiveExperimentalModels {
ActivateModels() { this = "jsch-os-injection" }
}
Expand Down
1 change: 1 addition & 0 deletions java/ql/src/experimental/Security/CWE/CWE-200/AndroidWebResourceResponse.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ private import semmle.code.java.dataflow.ExternalFlow
private import semmle.code.java.dataflow.FlowSteps
private import semmle.code.java.frameworks.android.WebView

overlay[local?]
private class ActivateModels extends ActiveExperimentalModels {
ActivateModels() { this = "android-web-resource-response" }
}
Expand Down
1 change: 1 addition & 0 deletions java/ql/src/experimental/Security/CWE/CWE-400/ThreadResourceAbuse.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import semmle.code.java.arithmetic.Overflow
import semmle.code.java.dataflow.FlowSteps
import semmle.code.java.controlflow.Guards

overlay[local?]
private class ActivateModels extends ActiveExperimentalModels {
ActivateModels() { this = "thread-resource-abuse" }
}
Expand Down
1 change: 1 addition & 0 deletions java/ql/src/experimental/Security/CWE/CWE-625/PermissiveDotRegexQuery.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import semmle.code.java.controlflow.Guards
import semmle.code.java.security.UrlRedirect
import Regex

overlay[local?]
private class ActivateModels extends ActiveExperimentalModels {
ActivateModels() { this = "permissive-dot-regex-query" }
}
Expand Down
1 change: 1 addition & 0 deletions shared/dataflow/codeql/dataflow/internal/DataFlowImplCommon.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,7 @@ module MakeImplCommon<LocationSig Location, InputSig<Location> Lang> {
* to `lambdaCall`, if any. That is, `lastCall` is able to target the enclosing
* callable of `lambdaCall`.
*/
overlay[global]
pragma[nomagic]
predicate revLambdaFlow(
Call lambdaCall, LambdaCallKind kind, Node node, Type t, boolean toReturn, boolean toJump,
Expand Down
0