8000 Rust: Add Operation class by geoffw0 · Pull Request #19454 · github/codeql · GitHub
[go: up one dir, main page]
Skip to content

Rust: Add Operation class #19454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 13, 2025
Merged

Rust: Add Operation class #19454

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
93f8cea
Rust: Add + clean up some QLDoc.
geoffw0 Apr 9, 2025
f64e86f
Rust: Add a library test for Operations.
geoffw0 Apr 9, 2025
060d515
Rust: Add an Operation class above LogicalOperation, AssignmentOperat…
geoffw0 Apr 9, 2025
be20176
Rust: Unify getAnOperand() methods into Operation.
geoffw0 May 2, 2025
dc1b4fc
Rust: Unify getOperatorName() methods into Operation.
geoffw0 May 2, 2025
09dc7fc
Rust: Autoformat.
geoffw0 May 2, 2025
48b95f3
Rust: Move OperationImpl to internal/OperationImpl.qll.
geoffw0 May 9, 2025
9160036 8000
Rust: Rename OperationImpl -> Impl.
geoffw0 May 12, 2025
a2944cd
Rust: Make usage of Impl more consistent with other Impl modules.
geoffw0 May 12, 2025
b3dc7a2
Apply suggestions from code review
geoffw0 May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rust: Make usage of Impl more consistent with other Impl modules.
  • Loading branch information
@geoffw0
geoffw0 committed May 12, 2025
commit a2944cdb61c6af07b7ccd57745c6211648b08d10
4 changes: 2 additions & 2 deletions rust/ql/lib/codeql/rust/elements/Operation.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* Provides classes for operations.
*/

import internal.OperationImpl::Impl as OperationImpl
private import internal.OperationImpl
private import codeql.rust.elements.internal.ExprImpl::Impl as ExprImpl

final class Operation = OperationImpl::Operation;
final class Operation = Impl::Operation;
2 changes: 1 addition & 1 deletion rust/ql/lib/codeql/rust/elements/internal/BinaryExprImpl.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
*/

private import codeql.rust.elements.internal.generated.BinaryExpr
private import codeql.rust.elements.Operation::OperationImpl as OperationImpl
private import codeql.rust.elements.internal.OperationImpl::Impl as OperationImpl

/**
* INTERNAL: This module contains the customizable definition of `BinaryExpr` and should not
Expand Down
2 changes: 1 addition & 1 deletion rust/ql/lib/codeql/rust/elements/internal/PrefixExprImpl.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
*/

private import codeql.rust.elements.internal.generated.PrefixExpr
private import codeql.rust.elements.Operation::OperationImpl as OperationImpl
private import codeql.rust.elements.internal.OperationImpl::Impl as OperationImpl

/**
* INTERNAL: This module contains the customizable definition of `PrefixExpr` and should not
Expand Down
0