Rust: Resolve Self path in trait type of implementation
#19227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a test case to verify that the Self path in the trait type of an implementation is correctly resolved. The changes introduce a new module (m23) with a trait (Trait1) and its implementation for a struct S using Self, and then exercise the implementation via a function call.
Files not reviewed (2)
- rust/ql/lib/codeql/rust/internal/PathResolution.qll: Language not supported
- rust/ql/test/library-tests/path-resolution/path-resolution.expected: Language not supported
Comments suppressed due to low confidence (1)
rust/ql/test/library-tests/path-resolution/main.rs:539
- [nitpick] Consider adding an assertion to verify that the resolution of 'Self' has been correctly applied rather than solely relying on printed output, to improve the test coverage.
println!("m23::<S as Trait1<S>>::f");
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
hvitved
requested changes
Apr 7, 2025
Contributor
There was a problem hiding this comment.
LGTM, one trivial request. Also, remember DCA.
| trait Trait1< | ||
| T // I1 | ||
| > { | ||
| fn f(&self); // // I3 |
hvitved
approved these changes
Apr 7, 2025
Contributor
Author
|
Absolutely nothing happened in the DCA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently don't resolve the
Selfin: