8000 Go: report any extracted file as successfully extracted by owen-mc · Pull Request #15211 · github/codeql · GitHub
[go: up one dir, main page]
Skip to content

Go: report any extracted file as successfully extracted #15211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Go: report any extracted file as successfully extracted #15211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f8b5bc
Go: report any extracted file as successfully extracted
owen-mc Jan 2, 2024
13b00ba
Update test expectation
owen-mc Jan 2, 2024
File filter

Filter by extension

Filter by extension
10000
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions go/ql/lib/change-notes/2024-01-02-go-successfully-extracted.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: minorAnalysis
---
* The diagnostic query `go/diagnostics/successfully-extracted-files`, and therefore the Code Scanning UI measure of scanned Go files, now considers any Go file seen during extraction, even one with some errors, to be extracted / scanned.
8 changes: 3 additions & 5 deletions go/ql/src/Diagnostics/SuccessfullyExtractedFiles.ql
< B412 a href="/owen-mc/codeql/blob/13b00bae170dd933e4467908c85aca9a67e6dbb9/go/ql/src/Diagnostics/SuccessfullyExtractedFiles.ql" class="pl-5 dropdown-item btn-link" rel="nofollow" role="menuitem" data-ga-click="View file, click, location:files_changed_dropdown" > View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,13 @@
/**
* @id go/diagnostics/successfully-extracted-files
* @name Successfully analyzed files
* @description List all files that were successfully extracted.
* @name Extracted files
* @description List all files that were extracted.
* @kind diagnostic
* @tags successfully-extracted-files
*/

import go

from File f
where
not exists(Error e | e.getFile() = f) and
exists(f.getRelativePath())
where exists(f.getRelativePath())
select f, ""
2 changes: 2 additions & 0 deletions go/ql/test/query-tests/Diagnostics/SuccessfullyExtractedFiles.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
| ../../go.mod:0:0:0:0 | ../../go.mod | |
| badimport.go:0:0:0:0 | badimport.go | |
| type.go:0:0:0:0 | type.go | |
| util.go:0:0:0:0 | util.go | |
0