8000 [SPIKE] Stop TeamFoundation MEF exceptions when installing by jcansdale · Pull Request #970 · github/VisualStudio · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

[SPIKE] Stop TeamFoundation MEF exceptions when installing #970

Closed
wants to merge 23 commits into from
Closed

[SPIKE] Stop TeamFoundation MEF exceptions when installing #970

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
c4f272c
Attempt at unifying the GitHub.TeamFoundation projects
jcansdale Apr 19, 2017
b54b2b3
Refine ResolvingTeamExplorerNavigationItem attribute
jcansdale Apr 19, 2017
fbe282c
Make GitHub.TeamFoundation.14 work in VS 2015 and 2017
jcansdale Apr 19, 2017
25a516e
Fix all TeamFoundation MEF errors when installing
jcansdale Apr 25, 2017
b4a3532
Use single resolution context for all TeamFoundation factories
jcansdale Apr 25, 2017
045a58a
Restore improved clone support in TeamFoundation 15+
jcansdale Apr 25, 2017
973f664
Fixed RegistryHelper to work in VS 2015 and 2017
jcansdale Apr 25, 2017
e739f15
Fix duplicate PullRequestsNavigationItem
jcansdale Apr 25, 2017
fc37978
Use public consts in TeamExplorer attributes
jcansdale Apr 25, 2017
e57b441
Leave Export attributes on TeamFoundation.14/15 MEF types
jcansdale Apr 25, 2017
3f91b83
Load TeamFoundation assemblies using Assembly.LoadFrom
jcansdale Apr 26, 2017
18dd2f3
Ensure that Microsoft.TeamFoundation assemblies are loaded consistently
jcansdale Apr 26, 2017
69afd80
Fix CodeAnalysis errors and use VsOutputLogger
jcansdale Apr 26, 2017
25a17b3
Removed Export attributes from factory classes
jcansdale May 2, 2017
f8d0bec
Fixed for updated GitHubHomeSection constructor
jcansdale May 2, 2017
5ab04db
Update Microsoft.TeamFoundation versions to 15.0.0.0
jcansdale May 3, 2017
93323af
Remove redundant `GitHub.TeamFoundation.14` project
jcansdale May 3, 2017
1646ccf
Move `GitHub.TeamFoundation.14` files into `GitHub.TeamFoundation`
jcansdale May 3, 2017
50d079d
Export ITeamFoundationResolver not its implementation
jcansdale May 3, 2017
25bf061
Remove obsolete TEAMEXPLORER14 #ifdefs
jcansdale May 3, 2017
325adae
Follow Dispose pattern and make TeamFoundationResolver public/extensible
jcansdale May 3, 2017
6623701
Factor out PriorityAssemblyResolver
jcansdale May 3, 2017
e6895d8
Reference Microsoft.VisualStudio.Threading 14.0
jcansdale May 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commi 8000 t
Remove obsolete TEAMEXPLORER14 #ifdefs
  • Loading branch information
@jcansdale
jcansdale committed May 3, 2017
commit 25bf061e819dde25fdcca35dc14c44fbbecad247
5 changes: 1 addition & 4 deletions src/GitHub.TeamFoundation/Services/VSGitServices.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,13 +62,12 @@ public string GetLocalClonePathFromGitProvider()
/// <inheritdoc/>
public async Task Clone(string cloneUrl, string clonePath, bool recurseSubmodules, object progress = null)
{
#if (!TEAMEXPLORER14)
if (TeamFoundationVersion.Major >= 15)
{
await Clone15(cloneUrl, clonePath, recurseSubmodules, progress);
return;
}
#endif

await Clone14(cloneUrl, clonePath, recurseSubmodules);
}

Expand All @@ -82,7 +81,6 @@ async Task Clone14(string cloneUrl, string clonePath, bool recurseSubmodules)
await gitExt.WhenAnyValue(x => x.CanClone).Where(x => x).Take(1);
}

#if (!TEAMEXPLORER14)
public async Task Clone15(string cloneUrl, string clonePath, bool recurseSubmodules, object progress = null)
{
var gitExt = serviceProvider.GetService<IGitActionsExt>();
Expand All @@ -95,7 +93,6 @@ await Microsoft.VisualStudio.Shell.ThreadHelper.JoinableTaskFactory.RunAsync(asy
await gitExt.CloneAsync(cloneUrl, clonePath, recurseSubmodules, default(CancellationToken), typedProgress);
});
}
#endif

IGitRepositoryInfo GetRepoFromVS()
{
Expand Down
0