10000 Update GraphQL schema and add CheckConclusionState.(Skipped / Stale) by jcansdale · Pull Request #2471 · github/VisualStudio · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Update GraphQL schema and add CheckConclusionState.(Skipped / Stale) #2471

Merged
merged 5 commits into from
Mar 11, 2020

Conversation

jcansdale
Copy link
Collaborator
@jcansdale jcansdale commented Mar 11, 2020

The PR list was failing because new check conclusion states have been added. This updates the GraphQL schema and adds these new states.

What this PR does

  • Update to the latest GraphQL schema
  • Fix FromGraphQl so that knows about CheckConclusionState Skipped and Stale
  • Add extra null arguments to MentionableUsers and Comments

How to test

Questions

Which of the Avalonia PRs was using the new state and what does it look like now?

Fixes #2472

@jcansdale jcansdale requested review from StanleyGoldman and a user March 11, 2020 08:01
@jcansdale jcansdale added the bug label Mar 11, 2020
Copy link
Contributor
@grokys grokys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jcansdale that fixes it!

@jcansdale jcansdale merged commit f3f8dee into master Mar 11, 2020
@Sanaz
Copy link
Sanaz commented Mar 16, 2020

I have updated the extension to the latest version and still get the same error (#2472). Any ideas @jcansdale?

@jcansdale
Copy link
Collaborator Author

@Sanaz,

This fix hasn't been deployed to the VS Marketplace yet. Could you try installing a recent .vsix
artifact from master, e.g.:
https://github.com/github/VisualStudio/runs/513754957

Please let me know how you get on! 😄

@parto
Copy link
parto commented Mar 17, 2020

@jcansdale thanks. this fixes the issue.

A62E

@parto
Copy link
parto commented Mar 17, 2020

@jcansdale it has another problem though when trying to open a PR:
Screen Shot 2020-03-17 at 12 59 52 PM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not convert 'STALE' to CheckConclusionState
4 participants
0