8000 Allow cloning of repositories into empty directories by YuPeiHenry · Pull Request #2316 · github/VisualStudio · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Allow cloning of repositories into empty directories #2316

Merged
merged 15 commits into from
Apr 8, 2019
Merged

Allow cloning of repositories into empty directories #2316

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
7c998ec
Enable clone and disable open button on empty dir.
YuPeiHenry Apr 4, 2019
b7cd425
Add support for cloning into empty dir.
YuPeiHenry Apr 4, 2019
1618a86
Add tests for CloneService with empty directory.
YuPeiHenry Apr 4, 2019
43b5ef6
RepositoryCloneViewModel: Combine if condition.
YuPeiHenry Apr 4, 2019
933a105
Add tests for RespositoryCloneViewModel on empty directory.
YuPeiHenry Apr 4, 2019
37b05a7
Ammend some tests in RepositoryCloneServiceTests to not use data.
YuPeiHenry Apr 4, 2019
96d3844
Merge branch 'master' into 2250-allow-cloning-to-empty-dir
YuPeiHenry Apr 5, 2019
382969b
Merge branch 'master' into 2250-allow-cloning-to-empty-dir
StanleyGoldman Apr 5, 2019
c82ca09
Merge branch 'master' into 2250-allow-cloning-to-empty-dir
jcansdale Apr 5, 2019
473373c
Update error message for non-empty directory.
YuPeiHenry Apr 7, 2019
83095d5
Merge branch 'master' into 2250-allow-cloning-to-empty-dir
YuPeiHenry Apr 7, 2019
cb81d03
Copying english to all resources
StanleyGoldman Apr 8, 2019
68d7c8f
Simplifying logic
StanleyGoldman Apr 8, 2019
1d8e3e8
DestinationDirectoryEmpty is (should be) used responsibly and not cal…
StanleyGoldman Apr 8, 2019
ef0ed57
Update Resources.resx
StanleyGoldman Apr 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Ammend some tests in RepositoryCloneServiceTests to not use data.
  • Loading branch information
@YuPeiHenry
YuPeiHenry committed Apr 4, 2019
commit 37b05a7fcc129a029e4931bbf9785615ea862ae9
12 changes: 8 additions & 4 deletions test/GitHub.App.UnitTests/Services/RepositoryCloneServiceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,11 @@ await usageTracker.Received(numberOfCalls).IncrementCounter(
((MemberExpression)x.Body).Member.Name == counterName));
}

[TestCase("https://github.com/failing/url", @"c:\dev\bar")]
public async Task CleansDirectoryOnCloneFailed(string cloneUrl, string clonePath)
[Test]
public async Task CleansDirectoryOnCloneFailed()
{
var cloneUrl = "https://github.com/failing/url";
var clonePath = @"c:\dev\bar";
var operatingSystem = Substitute.For<IOperatingSystem>();
var vsGitServices = Substitute.For<IVSGitServices>();
vsGitServices.Clone(cloneUrl, clonePath, true).Returns(x => { throw new Exception(); });
Expand All @@ -136,9 +138,11 @@ public async Task CleansDirectoryOnCloneFailed(string cloneUrl, string clonePath
await vsGitServices.Received().Clone(cloneUrl, clonePath, true);
}

[TestCase("https://github.com/foo/bar", @"c:\empty\directory")]
public async Task CloneIntoEmptyDirectory(string cloneUrl, string clonePath)
[Test]
public async Task CloneIntoEmptyDirectory()
{
var cloneUrl = "https://github.com/foo/bar";
var clonePath = @"c:\empty\directory";
var operatingSystem = Substitute.For<IOperatingSystem>();
operatingSystem.Directory.DirectoryExists(clonePath).Returns(true);
operatingSystem.Directory.IsEmpty(clonePath).Returns(true);
Expand Down
0