This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Update to use modern version of LibGit2Sharp and use indent heuristic when diffing #2142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop using obsolete LigGit2Sharp methods. Also changed from using Task.Factory.StartNew to Task.Run.
28c2bc7 to
26f5e2d
Compare
Reference LibG 10000 it2Sharp that targets .NET 4.6
Pass gitHubFilePath not winFilePath to FakeDiffService.Diff.
f28091a to
128cfbe
Compare
IGitService knows about IRepository but not remote servers. IGitClient knows about remote git repositories. IGitService is a more appropriate home for Compare and CompareWith.
There is a bug where a renamed file is in a directory.
The new version of LibGit2Sharp expects / separators in Git paths. The previous version wasn't fussy.
bbffa93 to
cc43965
Compare
<
10000
a href="/github/VisualStudio/pull/2142/commits/f685a22d3831ffd6e88c5966850630d9ff9f877b" class="Link--secondary">f685a22
Check that path doesn't contain \ rather than automatically convert to use /.
Make private ExtractToTempFile method accept Git path.
| #pragma warning disable 0618 // TODO: Replace `Network.Fetch` with `Commands.Fetch`. | ||
| repository.Network.Fetch(remote, fetchOptions); | ||
| #pragma warning restore 0618 | ||
| repository.Network.Fetch(remoteName, new[] { "+refs/heads/*:refs/remotes/origin/*" }, fetchOptions); |
There was a problem hiding this comment.
I guess things have changed since this warning was disabled...
StanleyGoldman
approved these changes
Mar 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
Thanks @bording for the fast turnaround of the
net46PR! 🙏What this PR does
0.26.0LibGit2SharpmethodsCommitandTreeno longer accepting\in pathsCompareandCompareWithfromIGitClienttoIGitService(comparing files doesn't require the credentials ofGitClient)CompareandCompareWithmethods ofGitClientTo do
LibGit2Sharp 0.26.*from NuGet (not local version)\as a separator when looking upTreeentries. We should maybe add checks for this in case we're using\instead of/anywhere.How to test
Fixes #1469
Fixes #2144