8000 Exclude GitHub.TeamFoundation.14 Asset from VS2017 by jcansdale · Pull Request #1705 · github/VisualStudio · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Exclude GitHub.TeamFoundation.14 Asset from VS2017 #1705

Merged
merged 2 commits into from
Jun 18, 2018
Merged

Exclude GitHub.TeamFoundation.14 Asset from VS2017 #1705

merged 2 commits into from
Jun 18, 2018

Conversation

jcansdale
Copy link
Collaborator
@jcansdale jcansdale commented May 23, 2018 •
edited
Loading

What this PR does

Clean up MEF log when extension installed in Visual Studio 2017

  • Use TargetVersion="[14.0,15.0)" to exclude GitHub.TeamFoundation.14
    MEF component from VS2017

The source.extension.vsixmanifest now includes this:

    <Asset Type="Microsoft.VisualStudio.MefComponent" d:Source="Project" 
        d:ProjectName="GitHub.TeamFoundation.14"
        TargetVersion="[14.0,15.0)" Path="|GitHub.TeamFoundation.14|" />
    <Asset Type="Microsoft.VisualStudio.MefComponent" 
        d:Source="Project" d:ProjectName="GitHub.TeamFoundation.15"
        TargetVersion="[15.0,16.0)" Path="|GitHub.TeamFoundation.15|" />

Unfortunately the TargetVersion="[15.0,16.0)" won't be understood by Visual Studio 2015 (so its MEF log will remain dirty).

How to test

Install in Visual Studio 2017 and use the Clear MEF Component Cache extension to Show MEF Errors (it's on the Tools menu). This should now be empty in Visual Studio 2017.

Errors will still appear in Visual Studio 2015 (it doesn't support the TargetVersion attribute).

Fixes #1704

@jcansdale
Exclude GitHub.TeamFoundation.14 Asset from VS2017
c9703cd 
Use `TargetVersion="[14.0,15.0)"` to exclude `GitHub.TeamFoundation.14`
MEF component Asset from VS2017.
grokys
grokys approved these changes Jun 18, 2018
View reviewed changes
Copy link
Contributor
@grokys grokys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work for me!

@grokys grokys merged commit a83ebfe into github:master Jun 18, 2018
@jcansdale jcansdale mentioned this pull request Aug 7, 2018
Closed
@meaghanlewis meaghanlewis added this to the 2.5.3 milestone Aug 7, 2018
@jcansdale jcansdale mentioned this pull request Aug 23, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@grokys grokys grokys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.3
Development

Successfully merging this pull request may close these issues.
3 participants
@jcansdale @grokys @meaghanlewis
0