8000 Stop fighting NuGet by jcansdale · Pull Request #1325 · github/VisualStudio · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Stop fighting NuGet #1325

Merged
merged 4 commits into from
Nov 20, 2017
Merged

Stop fighting NuGet #1325

merged 4 commits into from
Nov 20, 2017

Conversation

jcansdale
Copy link
Collaborator

Every time we update NuGet packages, Visual Studio / NuGet likes to add
dependentAssembly elements to App.config files and NuGetPackageImportStamp elements to .csproj files. These can be a pain to tidy up after every change.

This PR simply adds the stuff NuGet wanted to add when the libgit2sharp package was updated. This will avoid having to clean up again next time a NuGet package is updated. The idea is to avoid fighting NuGet all the time.

Alternatively we might find that App.config files aren't actually nessesary and we can remove them from the solution. NuGet would probably still add them, but deleting them might be easier than editing them. Thoughts?

Adding it now so we're not fighting VS everytime we update a package.
@jcansdale jcansdale changed the base branch from master to fixes/1306-LibGit2Sharp-v2.3.1 November 17, 2017 10:42
@shana
Copy link
Contributor
shana commented Nov 17, 2017

Pretty sure app.config files are not used by extensions. The only app.config file that would be used is the one in DesignTimeStyleHelper, since that's an actuall app. I'd say delete them and add them to .gitignore so if they get added again they won't get accidentally pushed to the repo.

grokys
grokys previously approved these changes Nov 17, 2017
@jcansdale
Copy link
Collaborator Author

I'd say delete them and add them to .gitignore so if they get added again they won't get accidentally pushed to the repo.

Good plan. I'll try that and see if anything breaks.

@grokys
Copy link
Contributor
grokys commented Nov 17, 2017

The problem with deleting the app.config files and adding them to .gitignore is that they'll get added to the .csproj anyway. I guess the compile error this will cause will at least mean then get deleted again, but it's not ideal.

If I'm reading this issue right, there should be a way to disable writing them?

@shana
Copy link
Contributor
shana commented Nov 17, 2017

@grokys oh nice, yeah, let's do that!

@shana shana changed the base branch from fixes/1306-LibGit2Sharp-v2.3.1 to master November 17, 2017 14:28
@jcansdale
Copy link
Collaborator Author

I've confirmed that you can change the version of a NuGet package and the only changes in the diff are the version numbers in package.config / *.csproj.

@grokys grokys merged commit 1472d65 into master Nov 20, 2017
@grokys grokys deleted the fixes/1306-LibGit2Sharp-v2.3.1-with-junk branch November 20, 2017 10:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0