This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Remove RepositoryHost(s) #1283
Merged
Remove RepositoryHost(s) #1283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed `IConnection.Repositories` and `IConnectionManager.RefreshRepositories` and replaced them with `LocalRepositories` which acts as a central place to find known repositories. As part of this, also added `IReadOnlyObservableCollection` and `ObservableCollectionEx` because the BCL's `ReadOnlyObservableCollection` sucks. Made ` 8000 TrackingCollection` implement `IReadOnlyObservableCollection`.
Following advice by @shana.
This services the same purpose as `IConnectionRepositoryHostMap` served when `RepositoryHost` was still around: to provide access to the globally registered connection.
5 tasks
|
After removing the contents of the: |
…local-repositories
…connection-manager Conflicts: src/GitHub.InlineReviews/Services/PullRequestSessionManager.cs src/UnitTests/GitHub.VisualStudio/Services/ConnectionManagerTests.cs
shana
reviewed
Nov 6, 2017
|
|
||
| [ImportingConstructor] | ||
| public ModelServiceFactory( | ||
| IApiClientFactory apiClientFactory, |
There was a problem hiding this comment.
It would be better to use ISimpleApiClientFactory here, so we can slowly move away from IApiClientFactory and get rid of it.
There was a problem hiding this comment.
Yes, but ModelService still relies on IApiClient rather than ISimpleApiClient and needs the reactive stuff, so if we want to make that change it will have to be later I think.
shana
approved these changes
Nov 6, 2017
When creating a `ModelService`, ensure that the correct `AccountCacheItem` is inserted.
…local-repositories Conflicts: src/GitHub.VisualStudio/Services/ConnectionManager.cs
…connection-manager Conflicts: src/GitHub.App/Models/RepositoryHost.cs src/GitHub.App/Models/RepositoryHosts.cs src/GitHub.App/ViewModels/PullRequestListView 8000 Model.cs src/GitHub.VisualStudio/Services/ConnectionManager.cs
…remove-repositoryhosts Conflicts: src/GitHub.App/Models/RepositoryHost.cs src/GitHub.App/Models/RepositoryHosts.cs src/GitHub.App/Services/ModelService.cs src/GitHub.App/ViewModels/GistCreationViewModel.cs src/GitHub.App/ViewModels/LoginTabViewModel.cs src/GitHub.App/ViewModels/PullRequestCreationViewModel.cs src/GitHub.App/ViewModels/PullRequestDetailViewModel.cs src/GitHub.App/ViewModels/PullRequestListViewModel.cs src/GitHub.App/ViewModels/RepositoryCloneViewModel.cs src/GitHub.App/ViewModels/RepositoryCreationViewModel.cs src/GitHub.App/ViewModels/RepositoryPublishViewModel.cs src/GitHub.InlineReviews/Services/PullRequestSessionManager.cs
|
this PR looks good to me 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4B65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
RepositoryHostsandRepositoryHostand makes all clients that used them useConnectionManagerinstead.Current state: I think mostly done but not tested much.
Depends on #1280