8000 fix(ci): add integration test with docker image by mavogel · Pull Request #226 · git-chglog/git-chglog · GitHub
[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): add integration test with docker image #226

Merged
merged 21 commits into from
Feb 11, 2023
Merged

Conversation

mavogel
Copy link
Member
@mavogel mavogel commented Jan 24, 2023

What does this do / why do we need it?

the docker image is broken on ubuntu, however not on Darwin

How this PR fixes the problem?

Trying to reproduce the bug

Check lists

  • Test passed
  • Coding style (indentation, etc)

Which issue(s) does this PR fix?

#225

Signed-off-by: Manuel Vogel <mavogel@posteo.de>
@mavogel mavogel linked an issue Jan 24, 2023 that may be closed by this pull request
@coveralls
Copy link
coveralls commented Jan 24, 2023

Pull Request Test Coverage Report for Build 4150790253

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.786%

Totals Coverage Status
Change from base Build 3993620083: 0.0%
Covered Lines: 1849
Relevant Lines: 2408

💛 - Coveralls

@trim21
Copy link
Contributor
trim21 commented Jan 24, 2023

Better to use another repo for testing...

Signed-off-by: Manuel Vogel <mavogel@posteo.de>
Signed-off-by: Manuel Vogel <mavogel@posteo.de>
Signed-off-by: Manuel Vogel <mavogel@posteo.de>
@mavogel
Copy link
Member Author
mavogel commented Jan 24, 2023

kk. first I'll fix the macos docker stuff for reproduction. Any idea already what might have broken the build? need to investigate

@mavogel
Copy link
Member Author
mavogel commented Feb 11, 2023

follow up later #230

@mavogel mavogel added this to the v0.15.3 milestone Feb 11, 2023
@mavogel mavogel self-assigned this Feb 11, 2023
@mavogel mavogel merged commit f3cf5b6 into master Feb 11, 2023
@mavogel mavogel deleted the fix/docker-image branch February 11, 2023 09:54
@mavogel mavogel mentioned this pull request Feb 11, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker image broken in 0.15.2
3 participants
0