chore: use ldflags to pass version to build process (#127)

git-chglog · Mar 23, 2021 · 3113e42 · 3113e42
1 parent 9a0d584
commit 3113e42
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/Makefile b/Makefile
@@ -1,3 +1,7 @@
+VERSION?=$$(git describe --tags --always)
+
+LDFLAGS="-X main.version=$(VERSION)"
+
 .PHONY: clean
 clean:
 	rm -rf ./dist/
@@ -7,7 +11,7 @@ clean:
 
 .PHONY: build
 build:
-	go build -o git-chglog ./cmd/git-chglog
+	go build -ldflags=$(LDFLAGS) -o git-chglog ./cmd/git-chglog
 
 .PHONY: test
 test:

diff --git a/cmd/git-chglog/main.go b/cmd/git-chglog/main.go
@@ -12,6 +12,9 @@ import (
 	"github.com/urfave/cli/v2"
 )
 
+// version is passed in via LDFLAGS main.version
+var version string
+
 // CreateApp creates and initializes CLI application
 // with description, flags, version, etc.
 func CreateApp(actionFunc cli.ActionFunc) *cli.App {
@@ -74,7 +77,7 @@ func CreateApp(actionFunc cli.ActionFunc) *cli.App {
 	app := cli.NewApp()
 	app.Name = "git-chglog"
 	app.Usage = "todo usage for git-chglog"
-	app.Version = Version
+	app.Version = version
 
 	app.Flags = []cli.Flag{
 		// init

diff --git a/cmd/git-chglog/version.go b/cmd/git-chglog/version.go