8000 wip: fix widths to be responsive and bigger by default by lygaret · Pull Request #1450 · git-bug/git-bug · GitHub
[go: up one dir, main page]

Skip to content

wip: fix widths to be responsive and bigger by default #1450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

lygaret
Copy link
Contributor
@lygaret lygaret commented May 18, 2025

No description provided.

@lygaret
Copy link
Contributor Author
lygaret commented May 18, 2025
Screen.Recording.2025-05-18.at.4.09.56.PM.mov

@@ -14,9 +14,9 @@ import LabelMenu from './labels/LabelMenu';
*/
const useStyles = makeStyles((theme) => ({
main: {
maxWidth: 1000,
maxWidth: 1100,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to make this even larger, like around 1400-1600? i found that to be pretty comfortable on displays with widths between 2256 and 2560.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to rework the layout to be flex-based, and then we can use the breakpoints to make this whatever we'd like; an xxl breakpoint that maxes out at 1600 makes sense to me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but what about my buddy who has that ridiculous 5120x1440 samsung display? it'll look like a bug tracker for ants!

(i jest, i think 1600 is plenty fine for a max width)

Copy link
Contributor
@sudoforge sudoforge May 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refactoring to be flex-based sounds good to me. we can hold off on (extraneous) dimension-based refactoring until then.

@lygaret
Copy link
Contributor Author
lygaret commented May 23, 2025

@sudoforge I'm sorry I've been awol on this, works been crazy, and I'm out of town next week.

please expect another round after memorial day

@sudoforge
Copy link
Contributor
sudoforge commented May 23, 2025

@lygaret absolutely no reason to apologize - your contributions to this open source project have been fantastic and are much appreciated. by no means do you have any sort of obligation to any timeline, and we very much encourage you (like any other contributor) to not make git-bug a priority over responsibilities in real life :)

@sudoforge sudoforge changed the base branch from master to trunk June 7, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0