8000 BugFix - Accounts in account selector of assistant do not adapt in impersonation mode by Anurag9977 · Pull Request #6231 · ghostfolio/ghostfolio · GitHub
[go: up one dir, main page]
Skip to content

BugFix - Accounts in account selector of assistant do not adapt in impersonation mode #6231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Anurag9977 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

BugFix - Accounts in account selector of assistant do not adapt in impersonation mode #6231

Anurag9977 wants to merge 1 commit into from
+25 −5

Conversation

@Anurag9977
Copy link
@Anurag9977 Anurag9977 commented Jan 21, 2026

Closes #2944

I have updated the controller route handler for get user to fetch accounts according to whether impersonation Id is available. Below is a screenshot of the desired output.

Current User
image
image

Impersonated User
image
image

Please review once and let me know if I missed anything. Thanks.

@Anurag9977 Anurag9977 force-pushed the bugfix/accounts-in-account-selection-filter-do-not-adapt-in-impersonation-mode branch from bf3ad56 to 577051e Compare January 21, 2026 21:02
dtslvr
dtslvr requested changes Jan 23, 2026
View reviewed changes
Copy link
Member
@dtslvr dtslvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @Anurag9977! 😎
I have reviewed your changes and added a few comments.

@Anurag9977 Anurag9977 force-pushed the bugfix/accounts-in-account-selection-f 9CFD ilter-do-not-adapt-in-impersonation-mode branch from 577051e to 8a8324b Compare January 24, 2026 08:54
@Anurag9977
Copy link
Author
Anurag9977 commented Jan 24, 2026

@dtslvr - Thanks for the review and the suggestions. It was nice to get a quick recap on clean code practice. I have made the changes accordingly. 😄

@Anurag9977 Anurag9977 requested a review from dtslvr January 24, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtslvr dtslvr Awaiting requested review from dtslvr

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Accounts in account selector of assistant do not adapt in impersonation mode

2 participants

@Anurag9977 @dtslvr
0