10000 Enable ANSI colors on Windows 10+ by anzz1 · Pull Request #311 · ggml-org/llama.cpp · GitHub
[go: up one dir, main page]
Skip to content

Enable ANSI colors on Windows 10+ #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 21, 2023
Merged

Enable ANSI colors on Windows 10+ #311

merged 3 commits into from
Mar 21, 2023

Conversation

anzz1
Copy link
Contributor
@anzz1 anzz1 commented Mar 19, 2023 •
edited
Loading
  • On older versions (of Windows) function will silently fail without any ill effects
  • Only used when params.use_color==true ( --color )
  • No windows.h dependency

anzz1 added 2 commits March 20, 2023 01:52
@anzz1
Enable ANSI colors on Windows 10+
0fed2ab 
On older versions function will silently fail without any ill effects
@anzz1
Do not call SetConsoleMode if the mode is already set
b37e095
@gjmulder gjmulder added the bug Something isn't working label Mar 20, 2023
ggerganov
ggerganov reviewed Mar 21, 2023
View reviewed changes
@ggerganov ggerganov merged commit c86ba03 into ggml-org:master Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggerganov ggerganov ggerganov approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anzz1 @ggerganov @gjmulder
0