ggml-cpu : remove the weak alias trick #14221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaren
approved these changes
Jun 17, 2025
ggerganov
approved these changes
Jun 17, 2025
Nexesenex
added a commit
to Nexesenex/croco.cpp
that referenced
this pull request
Jun 18, 2025
This reverts commit 860a9e4.
Nexesenex
added a commit
to Nexesenex/croco.cpp
that referenced
this pull request
Jun 18, 2025
This reverts commit 860a9e4.
Nexesenex
added a commit
to Nexesenex/croco.cpp
that referenced
this pull request
Jun 18, 2025
This reverts commit 860a9e4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior of weak aliases is inconsistent across different compilers and linkers. This PR removes our reliance on them to prevent potential issues. We now manage the selection of native kernels manually instead of relying on the linker.
Fixes #14134, #14138.