8000 Add support for DistilBert by huydt84 · Pull Request #13907 · ggml-org/llama.cpp · GitHub
[go: up one dir, main page]

Skip to content

Add support for DistilBert #13907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 30, 2025
Merged

Add support for DistilBert #13907

merged 5 commits into from
May 30, 2025

Conversation

huydt84
Copy link
Contributor
@huydt84 huydt84 commented May 30, 2025

Not that helpful, but this is support for DistilBert

@github-actions github-actions bot added the python python script changes label May 30, 2025
@huydt84
Copy link
Contributor Author
huydt84 commented May 30, 2025

@CISC please check again

@CISC
Copy link
Collaborator
CISC commented May 30, 2025

Thanks, looks good, I'm sure this will be useful, I've seen a few dbert based models. :)

@huydt84
Copy link
Contributor Author
huydt84 commented May 30, 2025

On second thought, scratch that, we can change DistilBert to Bert arch and remove all this.

So will we do this, or keep DistilBert separated?

Copy link
Collaborator
@CISC CISC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove it, much cleaner this way.

@huydt84
Copy link
Contributor Author
huydt84 commented May 30, 2025

Remove it, much cleaner this way.

Done

@CISC CISC merged commit 291f2b6 into ggml-org:master May 30, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python python script changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0