-
Notifications
You must be signed in to change notification settings - Fork 12.4k
server: --offline mode #13804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
server: --offline mode #13804
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
21b5988
server: --offline mode
273a728
use LLAMA_OFFLINE env for --offline
ochafik 40712c5
Merge remote-tracking branch 'origin/master' into offline
ochafik bb213c6
fix signatures of ifdef'd function fallbacks
ochafik f7439cb
nit spaces
ochafik 31ea1b8
Update arg.cpp
ochafik 7f7d859
Merge remote-tracking branch 'origin/master' into offline
ochafik 0818ab2
refactor as suggested
ochafik f8074b9
merge branches
ochafik 2eb3c69
rm OFFLINE from server tests (LLAMA_OFFLINE=1 works)
ochafik 153a0b8
Update common/arg.cpp
ochafik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code branch will be trigger when
file_exists == false && offline == true
, so technically one of the condition insideif (offline)
below now become dead code.Instead, you can move the
if (offline)
to above ofif (file_exists)
. So if file exist, we completely skip reading metadataThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah ofc, rearranged to skip, thanks!