8000 convert : fix nomic-bert-moe mask token by CISC · Pull Request #13757 · ggml-org/llama.cpp · GitHub
[go: up one dir, main page]

Skip to content

convert : fix nomic-bert-moe mask token #13757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

CISC
Copy link
Collaborator
@CISC CISC commented May 24, 2025

While testing UGM tokenizer with nomic-embed-text-v2-moe I noticed that the mask token was not set correctly. This fixes conversion and sets the lstrip token attribute at runtime.

Also corrects an obvious vocab padding error (most likely no actual change for any model out there, but at least makes sense now).

cc/ @cebtenzzre

CISC added 3 commits May 24, 2025 20:53
also correct obvious vocab padding error (most likely no actual change for any model out there, but at least makes sense now)
@github-actions github-actions bot added the python python script changes label May 24, 2025
@CISC CISC requested a review from slaren May 24, 2025 19:08
@CISC
Copy link
Collaborator Author
CISC commented May 26, 2025

@slaren gentle ping

@slaren
Copy link
Member
slaren commented May 26, 2025

Sorry, I don't know this code enough to review it.

@CISC
Copy link
Collaborator Author
CISC commented May 27, 2025

Sorry, I don't know this code enough to review it.

Ok, maybe @compilade can take a look now after a well deserved post-NorthSec break. :)

@CISC CISC requested a review from compilade May 27, 2025 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python python script changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0