8000 vulkan: Disable coopmat/coopmat2/bfloat extensions if glslc doesn't support it by jeffbolznv · Pull Request #13696 · ggml-org/llama.cpp · GitHub
[go: up one dir, main page]

Skip to content

vulkan: Disable coopmat/coopmat2/bfloat extensions if glslc doesn't support it #13696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025

Conversation

jeffbolznv
Copy link
Collaborator

Detecting these as supported could lead to corruption, e.g. choosing coopmat1 spec constant values for use with the scalar shader variant.

@jeffbolznv jeffbolznv requested a review from 0cc4m May 21, 2025 21:17
@github-actions github-actions bot added Vulkan Issues specific to the Vulkan backend ggml changes relating to the ggml tensor library for machine learning labels May 21, 2025
Copy link
Collaborator
@0cc4m 0cc4m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested, but looks good to me.

@0cc4m 0cc4m merged commit c10ed6c into ggml-org:master May 23, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ggml changes relating to the ggml tensor library for machine learning Vulkan Issues specific to the Vulkan backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0