sycl: add find_package call for OpenCL #13643
Conversation
Co-authored-by: Romain Biessy <romain.biessy@codeplay.com>
|
Shouldn't the |
This is used when building oneDNN not when building llama, |
|
I think Svet makes a good point. This could be fixed in the generated oneDNN config file similarly to this PR: uxlfoundation/oneDNN#2768 |
|
This PR could resolve your issue during building oneDNN. This PR should be updated to oneDNN build script, instead of llama.cpp. |
|
I had misunderstood your comment there @sgeor255 , |
|
@AD2605, @Rbiessy, does this project use oneDNN main branch or you need a stable version with changes from uxlfoundation/oneDNN#2768? |
|
Hi @vpirogov , We mostly use oneDNN that comes with the oneAPI releases and that's what the users are encouraged to do as well. We came across this issue when using the nightly dpcpp with llama, and when doing so, we will be using the nightly build of oneDNN as well. Thus to answer your question, we do not require them in a stable release |
|
Thanks for clarifications, @AD2605! The change will be available in oneAPI 2025.3 release. |
The nightly dpcpp compiler recently stopped shipping libOpenCL.so.
So when one uses a nightly build of oneDNN built with the said nightly compiler, it links against the target
OpenCL::OpenCL(see this line), and when using this build of oneDNN in llama, it would expect the targetOpenCL::OpenCLto be available.This PR simply adds the
find_package(OpenCL)when using the nightly compiler to resolve the same.