-
Notifications
You must be signed in to change notification settings - Fork 12.5k
tool-call: refactor common chat / tool-call api (+ tests / fixes) #11900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
36092aa
address clang-tidy lints
ef9b91a
tool-call: massive refactoring
2f683f0
rm minja dep from util & common
7a04ebc
move minja to common/minja
ece941b
Update utils.hpp
aa09a3c
add common_chat_tool
7ae7560
force utf8 encoding in get_chat_template
646528a
fix json tools parsing
db2b44e
add json tools / messages parsing helpers to common
c7c8907
fix common_chat_msgs_parse_oaicompat
5f17156
concat multipart content in legacy template path
ee9b9d6
add name & tool_call_id to common_chat_msg
07f0ad0
Update test-chat.cpp
1acda5f
test & fix json<->msg conversions
a58e1fc
fix typo
103c840
fix content part string concat in legacy template branch
c154c02
test tools json conversions
3d41f1b
test content parts in test-chat
59c8059
fix clang-tidy lints in [test-]chat.*
1847cae
fix deepseek r1 slow test (no longer <think> opening w/ new template)
8462a51
fix lints in test-chat-template.cpp
80c432b
tweak test_calc_result expectations
42b29e1
fix double bos/eos jinja avoidance hack (was preventing inner bos/eos…
ce4ccf0
add common_chat_templates_source + rehab server template logs
cb31f08
fix msg lints
76f5d27
tool-call: allow empty tools w/ auto + grammar
34e4e22
fix & test grammar & json_schema w/ & w/o --jinja
1c6168b
Update test-chat-template.cpp
ae6b870
test & fix array message.content
1421037
fix links to prepare merge
d95a17c
Merge remote-tracking branch 'origin/master' into chat-cleanups
5a5ed7b
fix merge
dd5ef85
rm trailing spaces
2f2f0fa
Add missing <optional> include to chat.cpp
a58b9e5
tiny fix: somehow llama_token being defined in an extern c makes it l…
f999ff5
alternative fix for gcc c vs. c++ weirdness
55a7614
add missing <regex> include to test-chat-template
9d62f62
Update chat.hpp
da0982a
have common_chat_templates_init return a unique_ptr
7ddb454
chat.{hpp -> h}
d2969b8
build common_chat_templates_ptr earlier
fd2b8e1
use deleter functor for common_chat_templates_ptr
9a85439
Merge remote-tracking branch 'origin/master' into chat-cleanups
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update chat.hpp
- Loading branch information
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.