-
Notifications
You must be signed in to change notification settings - Fork 12k
Allow user to compile with any cuda version using github actions #10928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
IMO it's quite strange to include a workflow that is not intended to be used by us (but instead, being used by user via a fork). The workflow is never be triggered automatically, so maintainers never know if it passes or not. This defeats the whole point of having a CI. A cleaner approach would be that user creates a blank repo containing this workflow, and the |
Not sure why you would still want to stick with CI. This approach makes it more convenient for users to customize the build without requiring much effort to configure. Additionally, this is the first place users will check out. Pointing them elsewhere may not be very helpful. Ultimately, it's up to you to decide if it should be included. |
One can always use something like act to build the package locally, there is no need to create a fork even, |
Trying avoid any local configuration is the main point. There are many way to compile for sure. However, not everyone knows how to set it up. And it's not trivial for this project specifically. |
As the official releases have limited versions, this would fill the gap.