8000 Check if mesh is empty before drawing by snyball · Pull Request #1300 · ggez/ggez · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if mesh is empty before drawing #1300

Merged
merged 1 commit into from
Jan 10, 2025
8000
Merged

Check if mesh is empty before drawing #1300

merged 1 commit into from
Jan 10, 2025

Conversation

snyball
Copy link
Contributor
@snyball snyball commented Dec 28, 2024

This fixes a crash when an empty mesh is drawn to a canvas. This can easily happen in e.g debug renderers based on MeshBuilder, when the builder is flushed without anything having been drawn to it.

a1phyr
a1phyr approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member
@a1phyr a1phyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@a1phyr a1phyr merged commit a21a627 into ggez:devel Jan 10, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a1phyr a1phyr a1phyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snyball @a1phyr
0