8000 feat(nuxt): New example page by ArthurKnaus · Pull Request #916 · getsentry/sentry-wizard · GitHub
[go: up one dir, main page]

Skip to content

feat(nuxt): New example page #916

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2025
Merged

Conversation

ArthurKnaus
Copy link
Member

Redesign the example page & component for Nuxt.

Page

Screen.Recording.2025-03-27.at.09.28.35.mov

Component

Screen.Recording.2025-03-26.at.20.13.23.mov

Note:
Once getsentry/sentry-javascript#15780 is done, I will revisit this and show the adblocker warning only when needed.

@ArthurKnaus ArthurKnaus requested a review from s1gr1d March 27, 2025 08:36
Copy link
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against ed9635f

Copy link
codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.79%. Comparing base (f2674bf) to head (ed9635f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master     #916    +/-   ##
========================================
  Coverage   51.79%   51.79%            
========================================
  Files          53       53            
  Lines        3657     3657            
  Branches      854      866    +12     
========================================
  Hits         1894     1894            
+ Misses       1762     1633   -129     
- Partials        1      130   +129     
Flag Coverage Δ
e2e-tests 80.28% <ø> (ø)
unit-tests 50.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member
@s1gr1d s1gr1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM 💯

@ArthurKnaus ArthurKnaus merged commit 768263a into master Mar 27, 2025
20 checks passed
@ArthurKnaus ArthurKnaus deleted the aknaus/feat/nuxt/new-example-page branch March 27, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0