E530 fix(rails): handle positioned binds in logging by solnic · Pull Request #2787 · getsentry/sentry-ruby · GitHub
[go: up one dir, main page]
Skip to content

fix(rails): handle positioned binds in logging#2787

Merged
solnic merged 2 commits intomasterfrom
2786-activerecordsubscriber-fails-even-sooner-on-queries-using-unnamed-binds
Nov 24, 2025
Merged

fix(rails): handle positioned binds in logging#2787
solnic merged 2 commits intomasterfrom
2786-activerecordsubscriber-fails-even-sooner-on-queries-using-unnamed-binds

Conversation

@solnic
Copy link
Collaborator
@solnic solnic commented Nov 24, 2025 •
edited
Loading

Now binds that are positional instead of named works too

image

Fixes #2786

@solnic solnic linked an issue Nov 24, 2025 that may be closed by this pull request
ActiveRecordSubscriber fails even sooner on queries using unnamed binds #2786
Closed
@solnic solnic force-pushed the 2786-activerecordsubscriber-fails-even-sooner-on-queries-using-unnamed-binds branch from a11b027 to 0613dfc Compare November 24, 2025 08:31
@solnic solnic force-pushed the 2786-activerecordsubscriber-fails-even-sooner-on-queries-using-unnamed-binds branch from 0613dfc to ce36b19 Compare November 24, 2025 08:50
@solnic solnic marked this pull request as ready for review November 24, 2025 09:01
@solnic solnic merged commit a5cee1b into master Nov 24, 2025
126 checks passed
@solnic solnic deleted the 2786-activerecordsubscriber-fails-even-sooner-on-queries-using-unnamed-binds branch November 24, 2025 09:57
@codecov
Copy link
codecov bot commented Nov 24, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.15%. Comparing base (17d6e49) to head (379b7ee).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../rails/log_subscribers/active_record_subscriber.rb 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2787      +/-   ##
==========================================
- Coverage   90.17%   90.15%   -0.02%     
==========================================
  Files         132      132              
  Lines        5292     5293       +1     
==========================================
  Hits         4772     4772              
- Misses        520      521       +1
Components Coverage Δ
sentry-ruby 97.26% <ø> (ø)
sentry-rails 55.54% <0.00%> (-0.07%) ⬇️
sentry-sidekiq 95.05% <ø> (ø)
sentry-resque 94.44% <ø> (ø)
sentry-delayed_job 94.68% <ø> (ø)
sentry-opentelemetry 99.31% <ø> (ø)
Files with missing lines Coverage Δ
.../rails/log_subscribers/active_record_subscriber.rb 26.02% <0.00%> (-0.37%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dingsdax dingsdax dingsdax approved these changes

@sl0thentr0py sl0thentr0py sl0thentr0py approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ActiveRecordSubscriber fails even sooner on queries using unnamed binds

3 participants

@solnic @dingsdax @sl0thentr0py
0