8000 feat: Sanic integration by untitaker · Pull Request #85 · getsentry/sentry-python · GitHub
[go: up one dir, main page]
Skip to content

feat: Sanic integration #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 27, 2018
Merged

feat: Sanic integration #85

merged 3 commits into from
Sep 27, 2018

Conversation

untitaker
Copy link
Member
@untitaker untitaker commented Sep 26, 2018 •
edited
Loading

support for older versions seems nontrivial. In particular testing against 0.7 just locks up

@untitaker untitaker requested a review from mitsuhiko September 26, 2018 13:54
@mitsuhiko
Copy link
Contributor

How much does this diverge from aiohttp? I wonder if we can just have an aiohttp integration that then automatically supports most of sanic.

@untitaker
Copy link
Member Author

I haven't looked into it but aiohttp isn't a dependency of sanic. I only need it for testing.

@untitaker
Copy link
Member Author

ping @mitsuhiko, want to get this out

mitsuhiko
mitsuhiko approved these changes Sep 27, 2018
View reviewed changes
Copy link
Contributor
@mitsuhiko mitsuhiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me. I thought the request object came from aiohttp but evidently not.

@untitaker untitaker merged commit 07a1e9c into master Sep 27, 2018
@untitaker untitaker deleted the feat/sanic-integration branch September 27, 2018 10:00
@untitaker untitaker mentioned this pull request Sep 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitsuhiko mitsuhiko mitsuhiko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@untitaker @mitsuhiko
0