8000 feat: Instrument ASGI under Django 3.0 by untitaker · Pull Request #573 · getsentry/sentry-python · GitHub
[go: up one dir, main page]
Skip to content

feat: Instrument ASGI under Django 3.0 #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 11, 2019
Merged

feat: Instrument ASGI under Django 3.0 #573

merged 2 commits into from
Dec 11, 2019

Conversation

untitaker
Copy link
Member
@untitaker untitaker commented Dec 4, 2019 •
edited
Loading

Django 3.0 has been released and we need this for proper scope management, less leaks and better request data.

rhcarvalho
rhcarvalho reviewed Dec 6, 2019
View reviewed changes
Copy link
Contributor
@rhcarvalho rhcarvalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Markus! Thanks for the opportunity to get more acquainted with sentry-python :)

Looks like a reasonable change. What I'm missing is how is it tested?

A couple questions inline for my education. Thanks!!!

rhcarvalho
rhcarvalho reviewed Dec 10, 2019
View reviewed changes
rhcarvalho
rhcarvalho approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor
@rhcarvalho rhcarvalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@untitaker untitaker merged commit 19200af into master Dec 11, 2019
@untitaker untitaker deleted the feat/django-3.0-asgi branch December 11, 2019 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhcarvalho rhcarvalho rhcarvalho approved these changes

@mitsuhiko mitsuhiko Awaiting requested review from mitsuhiko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@untitaker @rhcarvalho
0