8000 Better checking for empty tools list by antonpirker · Pull Request #4647 · getsentry/sentry-python · GitHub
[go: up one dir, main page]
Skip to content

Better checking for empty tools list #4647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
antonpirker merged 5 commits into from
Jul 30, 2025
Merged

Better checking for empty tools list #4647

antonpirker merged 5 commits into from
Jul 30, 2025
8000

Conversation

@antonpirker
Copy link
Contributor
@antonpirker antonpirker commented Jul 30, 2025

Fixes #4646

@antonpirker antonpirker requested a review from a team as a code owner July 30, 2025 12:53
cursor[bot]

This comment was marked as outdated.

Sign in to view

@codecov
Copy link
codecov bot commented Jul 30, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.73%. Comparing base (70e2b59) to head (8d89584).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/integrations/openai.py 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4647      +/-   ##
==========================================
- Coverage   80.75%   80.73%   -0.02%     
==========================================
  Files         156      156              
  Lines       16632    16636       +4     
  Branches     2831     2831              
==========================================
  Hits        13431    13431              
- Misses       2312     2313       +1     
- Partials      889      892       +3
Files with missing lines Coverage Δ
sentry_sdk/integrations/openai.py 84.41% <83.33%> (+0.16%) ⬆️

... and 2 files with indirect coverage changes

@antonpirker antonpirker merged commit 493ac4b into master Jul 30, 2025
138 checks passed
@antonpirker antonpirker deleted the antonpirker/fix-openai branch July 30, 2025 16:02
Sign up for free to join this conversatio 736F n on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@sentrivana sentrivana sentrivana approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

OpenAI Integration: TypeError: object of type 'NotGiven' has no len()

3 participants

@antonpirker @sentrivana
0