8000 feat: Capture spans for Celery's apply_async by dcramer · Pull Request #454 · getsentry/sentry-python · GitHub
[go: up one dir, main page]

Skip to content

feat: Capture spans for Celery's apply_async #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2019
Merged

Conversation

dcramer
Copy link
Member
@dcramer dcramer commented Aug 7, 2019

No description provided.

@dcramer
Copy link
Member Author
dcramer commented Aug 7, 2019

Just throwing this up for visibility/feedback. I think it'd be a useful stock instrumentation, but maybe t 8000 here are better attributes to expose as part of it.

@dcramer dcramer force-pushed the feat/celery-spans branch from bb4c1ad to 359c228 Compare August 7, 2019 19:21
Copy link
Member
@untitaker untitaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can actually merge this as-is and then iterate on it.

@untitaker untitaker merged commit b25ddfb into master Aug 8, 2019
@untitaker untitaker deleted the feat/celery-spans branch August 8, 2019 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0