8000 Migrate typing for integrations - part 2 by sl0thentr0py · Pull Request #4530 · getsentry/sentry-python · GitHub
[go: up one dir, main page]
Skip to content

Migrate typing for integrations - part 2 #4530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2025
Merged

Migrate typing for integrations - part 2 #4530

merged 1 commit into from
Jun 30, 2025

Conversation

sl0thentr0py
Copy link
Member

No description provided.

@sl0thentr0py sl0thentr0py requested a review from a team as a code owner June 26, 2025 13:44
@codecov Codecov
Copy link
codecov bot commented Jun 26, 2025 •
edited
Loading

❌ 24 Tests Failed:

Tests completed Failed Passed Skipped
20789 24 20765 4355
View the top 3 failed test(s) by shortest run time 
tests.integrations.aws_lambda.test_aws_lambda::test_headers[empty list headers]
Stack Traces | 0s run time 
.../integrations/aws_lambda/test_aws_lambda.py:70: in test_environment
    LocalLambdaStack.wait_for_stack(log_file=debug_log_file)
.../integrations/aws_lambda/utils.py:221: in wait_for_stack
    raise TimeoutError(
E   TimeoutError: AWS SAM failed to start within 60 seconds. (Maybe Docker is not running, or new docker images could not be built in time?) Check the log for more details: /tmp/sentry_aws_lambda_tests_sam_debug.log
tests.integrations.aws_lambda.test_aws_lambda::test_init_error
Stack Traces | 0s run time 
.../integrations/aws_lambda/test_aws_lambda.py:70: in test_environment
    LocalLambdaStack.wait_for_stack(log_file=debug_log_file)
.../integrations/aws_lambda/utils.py:221: in wait_for_stack
    raise TimeoutError(
E   TimeoutError: AWS SAM failed to start within 60 seconds. (Maybe Docker is not running, or new docker images could not be built in time?) Check the log for more details: /tmp/sentry_aws_lambda_tests_sam_debug.log
tests.integrations.aws_lambda.test_aws_lambda::test_timeout_error
Stack Traces | 0s run time 
.../integrations/aws_lambda/test_aws_lambda.py:70: in test_environment
    LocalLambdaStack.wait_for_stack(log_file=debug_log_file)
.../integrations/aws_lambda/utils.py:221: in wait_for_stack
    raise TimeoutError(
E   TimeoutError: AWS SAM failed to start within 60 seconds. (Maybe Docker is not running, or new docker images could not be built in time?) Check the log for more details: /tmp/sentry_aws_lambda_tests_sam_debug.log

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Base automatically changed from neel/typing-integrations-1 to neel/typing June 27, 2025 13:00
@sl0thentr0py sl0thentr0py force-pushed the neel/typing-integrations-2 branch from 35c514d to f109f85 Compare June 27, 2025 13:03
@sl0thentr0py sl0thentr0py mentioned this pull request Jun 27, 2025
Merged
@sl0thentr0py sl0thentr0py merged commit d99a8a2 into neel/typing Jun 30, 2025
133 of 136 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/typing-integrations-2 branch June 30, 2025 10:38
sl0thentr0py added a commit that referenced this pull request Jun 30, 2025
@sl0thentr0py
Migrate typing (#4500)
b07438d 
extracted from
https://github.com/getsentry/sentry-python/pull/4487/files with lots of
manual fixes

* migrate old style `# type: bla` to inline types
* most importantly use
[`__future__.annotations`](https://peps.python.org/pep-0563/#enabling-the-future-behavior-in-python-3-7)
so that we can simply use forward annotations without wrapping them in
strings like we did before, this simplifies things substantially
* also guard only things that shouldn't be imported under
`TYPE_CHECKING`, in the future it seems we should avoid using
`TYPE_CHECKING` completely
* #4510
* #4522
* #4529
* #4530
* #4532
* #4533
* #4534

closes #2585
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sentrivana sentrivana sentrivana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sl0thentr0py @sentrivana
0