10000 Set tool span to failed if an error is raised in the tool by antonpirker · Pull Request #4527 · getsentry/sentry-python · GitHub
[go: up one dir, main page]
Skip to content

Set tool span to failed if an error is raised in the tool #4527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 26, 2025
Merged

Set tool span to failed if an error is raised in the tool #4527

merged 2 commits into from
Jun 26, 2025

Conversation

antonpirker
Copy link
Member

No description provided.

@antonpirker antonpirker marked this pull request as ready for review June 26, 2025 12:10
@antonpirker antonpirker requested a review from a team as a code owner June 26, 2025 12:10
sentrivana
sentrivana approved these changes Jun 26, 2025
View reviewed changes
@codecov Codecov
Copy link
codecov bot commented Jun 26, 2025 •
edited
Loading

❌ 436 Tests Failed:

Tests completed Failed Passed Skipped
24193 436 23757 5801
View the top 3 failed test(s) by shortest run time 
tests.test_metrics::test_timing_decorator[greenlet]
Stack Traces | 0.337s run time 
tests/conftest.py:350: in maybe_monkeypatched_threading
    gevent.monkey.patch_all()
.tox/py3.11-gevent/lib/python3.11....../site-packages/gevent/monkey.py:1255: in patch_all
    _notify_patch(events.GeventWillPatchAllEvent(modules_to_patch, kwargs), _warnings)
.tox/py3.11-gevent/lib/python3.11....../site-packages/gevent/monkey.py:190: in _notify_patch
    notify_and_call_entry_points(event)
.tox/py3.11-gevent/lib/python3.11.../site-packages/gevent/events.py:104: in notify_and_call_entry_points
    subscriber = plugin.load()
                 ^^^^^^^^^^^^^
.tox/py3.11-gevent/lib/python3.11............/site-packages/pkg_resources/__init__.py:2481: in load
    self.require(*args, **kwargs)
.tox/py3.11-gevent/lib/python3.11............/site-packages/pkg_resources/__init__.py:2504: in require
    items = working_set.resolve(reqs, env, installer, extras=self.extras)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
.tox/py3.11-gevent/lib/python3.11............/site-packages/pkg_resources/__init__.py:798: in resolve
    dist = self._resolve_dist(
.tox/py3.11-gevent/lib/python3.11............/site-packages/pkg_resources/__init__.py:839: in _resolve_dist
    raise DistributionNotFound(req, requirers)
E   pkg_resources.DistributionNotFound: The 'zope.event' distribution was not found and is required by the application
tests.test_metrics::test_metric_summaries[greenlet]
Stack Traces | 0.339s run time 
tests/conftest.py:350: in maybe_monkeypatched_threading
    gevent.monkey.patch_all()
.tox/py3.11-gevent/lib/python3.11....../site-packages/gevent/monkey.py:1255: in patch_all
    _notify_patch(events.GeventWillPatchAllEvent(modules_to_patch, kwargs), _warnings)
.tox/py3.11-gevent/lib/python3.11....../site-packages/gevent/monkey.py:190: in _notify_patch
    notify_and_call_entry_points(event)
.tox/py3.11-gevent/lib/python3.11.../site-packages/gevent/events.py:104: in notify_and_call_entry_points
    subscriber = plugin.load()
                 ^^^^^^^^^^^^^
.tox/py3.11-gevent/lib/python3.11............/site-packages/pkg_resources/__init__.py:2481: in load
    self.require(*args, **kwargs)
.tox/py3.11-gevent/lib/python3.11............/site-packages/pkg_resources/__init__.py:2504: in require
    items = working_set.resolve(reqs, env, installer, extras=self.extras)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
.tox/py3.11-gevent/lib/python3.11............/site-packages/pkg_resources/__init__.py:798: in resolve
    dist = self._resolve_dist(
.tox/py3.11-gevent/lib/python3.11............/site-packages/pkg_resources/__init__.py:839: in _resolve_dist
    raise DistributionNotFound(req, requirers)
E   pkg_resources.DistributionNotFound: The 'zope.event' distribution was not found and is required by the application
tests.test_metrics::test_timing[greenlet]
Stack Traces | 0.339s run time 
tests/conftest.py:350: in maybe_monkeypatched_threading
    gevent.monkey.patch_all()
.tox/py3.11-gevent/lib/python3.11....../site-packages/gevent/monkey.py:1255: in patch_all
    _notify_patch(events.GeventWillPatchAllEvent(modules_to_patch, kwargs), _warnings)
.tox/py3.11-gevent/lib/python3.11....../site-packages/gevent/monkey.py:190: in _notify_patch
    notify_and_call_entry_points(event)
.tox/py3.11-gevent/lib/python3.11.../site-packages/gevent/events.py:104: in notify_and_call_entry_points
    subscriber = plugin.load()
                 ^^^^^^^^^^^^^
.tox/py3.11-gevent/lib/python3.11............/site-packages/pkg_resources/__init__.py:2481: in load
    self.require(*args, **kwargs)
.tox/py3.11-gevent/lib/python3.11............/site-packages/pkg_resources/__init__.py:2504: in require
    items = working_set.resolve(reqs, env, installer, extras=self.extras)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
.tox/py3.11-gevent/lib/python3.11............/site-packages/pkg_resources/__init__.py:798: in resolve
    dist = self._resolve_dist(
.tox/py3.11-gevent/lib/python3.11............/site-packages/pkg_resources/__init__.py:839: in _resolve_dist
    raise DistributionNotFound(req, requirers)
E   pkg_resources.DistributionNotFound: The 'zope.event' distribution was not found and is required by the application

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@antonpirker @sentrivana
Update sentry_sdk/integrations/openai_agents/spans/execute_tool.py
b53751e 
Co-authored-by: Ivana Kellyer <ivana.kellyer@sentry.io>
@antonpirker antonpirker enabled auto-merge (squash) June 26, 2025 12:14
@antonpirker antonpirker merged commit 546ce1f into master Jun 26, 2025
133 of 136 checks passed
@antonpirker antonpirker deleted the antonpirker/update-openai-agents branch June 26, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sentrivana sentrivana sentrivana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonpirker @sentrivana
0