8000 fix: types for logging integration args by sbdchd · Pull Request #444 · getsentry/sentry-python · GitHub
[go: up one dir, main page]
Skip to content

fix: types for logging integration args #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 5, 2019
Merged

fix: types for logging integration args #444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
70d6d66
fix: types for logging integration args
sbdchd Jul 28, 2019
fc898bb
fix: type for integration's arg
sbdchd Jul 28, 2019
e0b0fa7
add missing import
sbdchd Jul 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
8000
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sentry_sdk/consts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
from typing import Type
from typing import Dict
from typing import Any
from typing import Sequence

from sentry_sdk.transport import Transport
from sentry_sdk.integrations import Integration
Expand All @@ -27,7 +28,7 @@ def __init__(
environment=None, # type: Optional[str]
server_name=None, # type: Optional[str]
shutdown_timeout=2, # type: int
integrations=[], # type: List[Integration]
integrations=[], # type: Sequence[Integration]
in_app_include=[], # type: List[str]
in_app_exclude=[], # type: List[str]
default_integrations=True, # type: bool
Expand Down
3 changes: 2 additions & 1 deletion sentry_sdk/integrations/logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
from logging import LogRecord
from typing import Any
from typing import Dict
from typing import Optional

DEFAULT_LEVEL = logging.INFO
DEFAULT_EVENT_LEVEL = logging.ERROR
Expand All @@ -40,7 +41,7 @@ class LoggingIntegration(Integration):
identifier = "logging"

def __init__(self, level=DEFAULT_LEVEL, event_level=DEFAULT_EVENT_LEVEL):
# type: (int, int) -> None
# type: (Optional[int], Optional[int]) -> None
self._handler = None
self._breadcrumb_handler = None

Expand Down
0