fix(tracing): Fix span nesting concurrency issues #4409
+169
−101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Tests completed | Failed | Passed | Skipped |
|---|---|---|---|
| 23935 | 64 | 23871 | 5876 |
View the top 3 failed test(s) by shortest run time
tests.integrations.clickhouse_driver.test_clickhouse_driver::test_clickhouse_client_breadcrumbs_with_piiStack Traces | 0s run time
tests/conftest.py:93: in _ reraise(*e) sentry_sdk/utils.py:1746: in reraise raise value sentry_sdk/integrations/clickhouse_driver.py:120: in _inner_end span.scope.add_breadcrumb( E AttributeError: 'NoneType' object has no attribute 'add_breadcrumb'
tests.integrations.clickhouse_driver.test_clickhouse_driver::test_clickhouse_dbapi_breadcrumbsStack Traces | 0s run time
tests/conftest.py:93: in _ reraise(*e) sentry_sdk/utils.py:1746: in reraise raise value sentry_sdk/integrations/clickhouse_driver.py:120: in _inner_end span.scope.add_breadcrumb( E AttributeError: 'NoneType' object has no attribute 'add_breadcrumb'
tests.integrations.langchain.test_langchain::test_langchain_agent[False-True-False]Stack Traces | 0s run time
tests/conftest.py:93: in _ reraise(*e) sentry_sdk/utils.py:1746: in reraise raise value sentry_sdk/integrations/langchain.py:332: in on_chain_end self._exit_span(span_data, run_id) sentry_sdk/integrations/langchain.py:164: in _exit_span span_data.span.__exit__(None, None, None) sentry_sdk/tracing.py:408: in __exit__ self.scope_manager.__exit__(ty, value, tb) .../hostedtoolcache/Python/3.12.10.../x64/lib/python3.12/contextlib.py:144: in __exit__ next(self.gen) sentry_sdk/scope.py:1681: in new_scope _current_scope.reset(token) E ValueError: <Token var=<ContextVar name='current_scope' default=None at 0x7fa99bd437e0> at 0x7fa98a32dec0> was created in a different Context
To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4241
Thank you for contributing to
sentry-python! Please add tests to validate your changes, and lint your code usingtox -e linters.Running the test suite on your PR might require maintainer approval.