-
Notifications
You must be signed in to change notification settings - Fork 544
fix(logs): send severity_text
: warn
instead of warning
#4396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tests completed | Failed | Passed | Skipped |
---|---|---|---|
23653 | 4 | 23649 | 5866 |
View the top 3 failed test(s) by shortest run time
tests.integrations.redis.cluster.test_redis_cluster::test_rediscluster_pipeline[False-expected_first_ten0]
Stack Traces | 0.088s run time
.../redis/cluster/test_redis_cluster.py:131: in test_rediscluster_pipeline assert span["data"] == ApproxDict( E assert {'thread.id': '140172275465088', 'thread.name': 'MainThread', 'db.system': 'redis', 'server.address': '127.0.0.1', 'server.port': 6379, 'redis.commands': {'count': 0, 'first_ten': []}} == {'redis.commands': {'count': 3, 'first_ten': ["GET 'foo'", "SET 'bar' [Filtered]", "SET 'baz' [Filtered]"]}, 'db.system': 'redis', 'server.address': '127.0.0.1', 'server.port': 6379} E Common items: E {'db.system': 'redis', 'server.address': '127.0.0.1', 'server.port': 6379} E Differing items: E {'redis.commands': {'count': 0, 'first_ten': []}} != {'redis.commands': {'count': 3, 'first_ten': ["GET 'foo'", "SET 'bar' [Filtered]", "SET 'baz' [Filtered]"]}} E Left contains 2 more items: E {'thread.id': '140172275465088', 'thread.name': 'MainThread'} E Full diff: E { E 'db.system': 'redis', E - 'redis.commands': {'count': 3, E ? ^ E + 'redis.commands': {'count': 0, E ? ^ E - 'first_ten': ["GET 'foo'", E ? ^^^^^^^^^^^ E + 'first_ten': []}, E ? ^^ E - "SET 'bar' [Filtered]", E - "SET 'baz' [Filtered]"]}, E 'server.address': '127.0.0.1', E 'server.port': 6379, E + 'thread.id': '140172275465088', E + 'thread.name': 'MainThread', E }
tests.integrations.redis.cluster.test_redis_cluster::test_rediscluster_pipeline[True-expected_first_ten1]
Stack Traces | 0.088s run time
.../redis/cluster/test_redis_cluster.py:131: in test_rediscluster_pipeline assert span["data"] == ApproxDict( E assert {'thread.id': '140172275465088', 'thread.name': 'MainThread', 'db.system': 'redis', 'server.address': '127.0.0.1', 'server.port': 6379, 'redis.commands': {'count': 0, 'first_ten': []}} == {'redis.commands': {'count': 3, 'first_ten': ["GET 'foo'", "SET 'bar' 1", "SET 'baz' 2"]}, 'db.system': 'redis', 'server.address': '127.0.0.1', 'server.port': 6379} E Common items: E {'db.system': 'redis', 'server.address': '127.0.0.1', 'server.port': 6379} E Differing items: E {'redis.commands': {'count': 0, 'first_ten': []}} != {'redis.commands': {'count': 3, 'first_ten': ["GET 'foo'", "SET 'bar' 1", "SET 'baz' 2"]}} E Left contains 2 more items: E {'thread.id': '140172275465088', 'thread.name': 'MainThread'} E Full diff: E { E 'db.system': 'redis', E - 'redis.commands': {'count': 3, E ? ^ E + 'redis.commands': {'count': 0, E ? ^ E - 'first_ten': ["GET 'foo'", E ? ^^^^^^^^^^^ E + 'first_ten': []}, E ? ^^ E - "SET 'bar' 1", E - "SET 'baz' 2"]}, E 'server.address': '127.0.0.1', E 'server.port': 6379, E + 'thread.id': '140172275465088', E + 'thread.name': 'MainThread', E }
tests.integrations.redis.cluster.test_redis_cluster::test_rediscluster_pipeline[True-expected_first_ten1]
Stack Traces | 0.097s run time
.../redis/cluster/test_redis_cluster.py:131: in test_rediscluster_pipeline assert span["data"] == ApproxDict( E assert {'thread.id': '140098163104640', 'thread.name': 'MainThread', 'db.system': 'redis', 'server.address': '127.0.0.1', 'server.port': 6379, 'redis.commands': {'count': 0, 'first_ten': []}} == {'redis.commands': {'count': 3, 'first_ten': ["GET 'foo'", "SET 'bar' 1", "SET 'baz' 2"]}, 'db.system': 'redis', 'server.address': '127.0.0.1', 'server.port': 6379} E Common items: E {'db.system': 'redis', 'server.address': '127.0.0.1', 'server.port': 6379} E Differing items: E {'redis.commands': {'count': 0, 'first_ten': []}} != {'redis.commands': {'count': 3, 'first_ten': ["GET 'foo'", "SET 'bar' 1", "SET 'baz' 2"]}} E Left contains 2 more items: E {'thread.id': '140098163104640', 'thread.name': 'MainThread'} E Full diff: E { E 'db.system': 'redis', E - 'redis.commands': {'count': 3, E ? ^ E + 'redis.commands': {'count': 0, E ? ^ E - 'first_ten': ["GET 'foo'", E ? ^^^^^^^^^^^ E + 'first_ten': []}, E ? ^^ E - "SET 'bar' 1", E - "SET 'baz' 2"]}, E 'server.address': '127.0.0.1', E 'server.port': 6379, E + 'thread.id': '140098163104640', E + 'thread.name': 'MainThread', E }
To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
b37fbba
to
aa8de97
Compare
It seems that previously I updated something that effected the |
We need to send
warn
as theseverity_text
for warning level logs, notwarning
.If we send
warning
it will not be recognized by the backend and the severity will show up asUNKNOWN
in the frontend.See screenshot for comparison of after and before.