8000 Make use of `SPANDATA` consistent in AI integrations.` by antonpirker · Pull Request #4376 · getsentry/sentry-python · GitHub
[go: up one dir, main page]
Skip to content

Make use of SPANDATA consistent in AI integrations.` #4376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2025
Merged

Make use of SPANDATA consistent in AI integrations.` #4376

merged 1 commit into from
May 9, 2025

Conversation

antonpirker
Copy link
Member

Not using plain strings, but always use SPANDATA. Follow up to this PR: #4373

@codecov Codecov
Copy link
codecov bot commented May 9, 2025 &# 8000 8226;
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.37%. Comparing base (bf0393b) to head (f48910a).
Report is 1 commits behind head on potel-base.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@             Coverage Diff             @@
##           potel-base    #4376   +/-   ##
===========================================
  Coverage       84.37%   84.37%           
===========================================
  Files             144      144           
  Lines           14691    14697    +6     
  Branches         2339     2339           
===========================================
+ Hits            12395    12401    +6     
  Misses           1567     1567           
  Partials          729      729
Files with missing lines Coverage Δ
sentry_sdk/ai/monitoring.py 88.73% <100.00%> (ø)
sentry_sdk/consts.py 99.59% <100.00%> (+0.01%) ⬆️

@antonpirker antonpirker marked this pull request as ready for review May 9, 2025 09:35
@antonpirker antonpirker requested a review from a team as a code owner May 9, 2025 09:35
szokeasaurusrex
szokeasaurusrex approved these changes May 9, 2025
View reviewed changes
Copy link
Member
@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did notice that there are fewer files changed here than in #4373 – I'm assuming these files don't exist in POTel?

@antonpirker
Copy link
Member Author

the other changes have already been made in the other PR. this one just adds the new occurences of not using SPANDATA that have been introduced in potel.

@antonpirker antonpirker merged commit 07ba0f0 into potel-base May 9, 2025
123 checks passed
@antonpirker antonpirker deleted the antonpirker/potel/spandata-consistency branch May 9, 2025 09:44
@szokeasaurusrex Linear
Copy link
Member

ah got it

@antonpirker antonpirker mentioned this pull request May 9, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szokeasaurusrex szokeasaurusrex szokeasaurusrex approved these changes

@sentrivana sentrivana sentrivana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antonpirker @szokeasaurusrex @sentrivana
0