8000 Add thread info to HTTP breadcrumbs by antonpirker · Pull Request #4368 · getsentry/sentry-python · GitHub
[go: up one dir, main page]
Skip to content

Add thread info to HTTP breadcrumbs #4368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 6, 2025
Merged

Add thread info to HTTP breadcrumbs #4368

merged 6 commits into from
May 6, 2025

Conversation

antonpirker
Copy link
Member

To preserve behavior form 2.x

@codecov Codecov
Copy link
codecov bot commented May 6, 2025 •
edited
Loading

❌ 6 Tests Failed:

Tests completed Failed Passed Skipped
20401 6 20395 4417
View the top 3 failed test(s) by shortest run time 
tests.integrations.redis.cluster.test_redis_cluster test_rediscluster_pipeline[False-expected_first_ten0]
Stack Traces | 0.095s run time 
.../redis/cluster/test_redis_cluster.py:121: in test_rediscluster_pipeline
    pipeline = rc.pipeline()
.../redis/cluster/test_redis_cluster.py:16: in <lambda>
    redis.RedisCluster.pipeline = lambda *_, **__: pipeline_cls(None, None)
.tox/py3.12-redis-latest/lib/python3.12.../site-packages/redis/utils.py:188: in wrapper
    return func(*args, **kwargs)
.tox/py3.12-redis-latest/lib/python3.12.../site-packages/redis/cluster.py:2125: in __init__
    retries=self.cluster_error_retry_attempts,
E   AttributeError: 'ClusterPipeline' object has no attribute 'cluster_error_retry_attempts'
tests.integrations.redis.cluster.test_redis_cluster test_rediscluster_pipeline[True-expected_first_ten1]
Stack Traces | 0.098s run time 
.../redis/cluster/test_redis_cluster.py:121: in test_rediscluster_pipeline
    pipeline = rc.pipeline()
.../redis/cluster/test_redis_cluster.py:16: in <lambda>
    redis.RedisCluster.pipeline = lambda *_, **__: pipeline_cls(None, None)
.tox/py3.12-redis-latest/lib/python3.12.../site-packages/redis/utils.py:188: in wrapper
    return func(*args, **kwargs)
.tox/py3.12-redis-latest/lib/python3.12.../site-packages/redis/cluster.py:2125: in __init__
    retries=self.cluster_error_retry_attempts,
E   AttributeError: 'ClusterPipeline' object has no attribute 'cluster_error_retry_attempts'
tests.integrations.redis.cluster.test_redis_cluster test_rediscluster_span_origin
Stack Traces | 0.098s run time 
.../redis/cluster/test_redis_cluster.py:160: in test_rediscluster_span_origin
    pipeline = rc.pipeline(transaction=False)
.../redis/cluster/test_redis_cluster.py:16: in <lambda>
    redis.RedisCluster.pipeline = lambda *_, **__: pipeline_cls(None, None)
.tox/py3.12-redis-latest/lib/python3.12.../site-packages/redis/utils.py:188: in wrapper
    return func(*args, **kwargs)
.tox/py3.12-redis-latest/lib/python3.12.../site-packages/redis/cluster.py:2125: in __init__
    retries=self.cluster_error_retry_attempts,
E   AttributeError: 'ClusterPipeline' object has no attribute 'cluster_error_retry_attempts'

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@antonpirker antonpirker mentioned this pull request May 6, 2025
Closed
@antonpirker antonpirker marked this pull request as ready for review May 6, 2025 11:50
@antonpirker antonpirker requested a review from a team as a code owner May 6, 2025 11:50
@antonpirker antonpirker merged commit 28ba185 into potel-base May 6, 2025
122 of 125 checks passed
@antonpirker antonpirker deleted the antonpirker/potel/breadcrumbs-thread-info branch May 6, 2025 12:04
@antonpirker antonpirker mentioned this pull request May 6, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sl0thentr0py sl0thentr0py sl0thentr0py approved these changes

@szokeasaurusrex szokeasaurusrex Awaiting requested review from szokeasaurusrex

@sentrivana sentrivana Awaiting requested review from sentrivana

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonpirker @sl0thentr0py
0