8000 ref: Drop `set_measurement` by sentrivana · Pull Request #4333 · getsentry/sentry-python · GitHub
[go: up one dir, main page]
Skip to content

ref: Drop set_measurement #4333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 28, 2025
Merged

ref: Drop set_measurement #4333

merged 3 commits into from
Apr 28, 2025

Conversation

sentrivana
Copy link
Contributor
@sentrivana sentrivana commented Apr 28, 2025 •
edited
Loading

Closes #4332

@sentrivana sentrivana linked an issue Apr 28, 2025 that may be closed by this pull request
Drop set_measurement on potel-base #4332
Closed
@sentrivana sentrivana changed the title ref: Drop set_measurement ref: Drop set_measurement Apr 28, 2025
@sentrivana sentrivana marked this pull request as ready for review April 28, 2025 11:56
@sentrivana sentrivana requested a review from a team as a code owner April 28, 2025 11:56
@codecov Codecov
Copy link
codecov bot commented Apr 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.37%. Comparing base (c47df82) to head (287e71e).
Report is 1 commits behind head on potel-base.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@             Coverage Diff             @@
##           potel-base    #4333   +/-   ##
===========================================
  Coverage       84.37%   84.37%           
===========================================
  Files             144      144           
  Lines           14647    14632   -15     
  Branches         2328     2325    -3     
===========================================
- Hits            12358    12346   -12     
+ Misses           1561     1560    -1     
+ Partials          728      726    -2
Files with missing lines Coverage Δ
sentry_sdk/__init__.py 100.00% <ø> (ø)
sentry_sdk/ai/monitoring.py 88.57% <100.00%> (ø)
sentry_sdk/api.py 96.38% <ø> (+0.98%) ⬆️
sentry_sdk/opentelemetry/consts.py 100.00% <ø> (ø)
sentry_sdk/opentelemetry/span_processor.py 81.36% <ø> (-0.35%) ⬇️
sentry_sdk/opentelemetry/utils.py 81.93% <100.00%> (-0.23%) ⬇️
sentry_sdk/tracing.py 80.49% <ø> (+0.07%) ⬆️

... and 1 file with indirect coverage changes

szokeasaurusrex
szokeasaurusrex requested changes Apr 28, 2025
View reviewed changes
Copy link
Member
@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, besides making sure that the data keys align with the span data conventions (which is why I am requesting changes)

@sentrivana @szokeasaurusrex
Apply suggestions from code review
9b0629d 
Co-authored-by: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
szokeasaurusrex
szokeasaurusrex approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member
@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@sentrivana sentrivana merged commit 40eae25 into potel-base Apr 28, 2025
129 checks passed
@sentrivana sentrivana deleted the ivana/potel/drop-set-measurement branch April 28, 2025 12:37
@sentrivana sentrivana mentioned this pull request Apr 28, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sl0thentr0py sl0thentr0py sl0thentr0py approved these changes

@szokeasaurusrex szokeasaurusrex szokeasaurusrex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop set_measurement on potel-base
3 participants
@sentrivana @sl0thentr0py @szokeasaurusrex
0