8000 feat(logging): Do not capture errors from `LoggingIntegration` to Sentry by default by antonpirker · Pull Request #4300 · getsentry/sentry-python · GitHub
[go: up one dir, main page]
Skip to content

feat(logging): Do not capture errors from LoggingIntegration to Sentry by default #4300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 15, 2025
Merged

feat(logging): Do not capture errors from LoggingIntegration to Sentry by default #4300

merged 6 commits into from
Apr 15, 2025

Conversation

antonpirker
Copy link
Member

Fixes #4187

@codecov Codecov
Copy link
codecov bot commented Apr 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.57%. Comparing base (a610066) to head (cd10f0f).
Report is 1 commits behind head on potel-base.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@              Coverage Diff               @@
##           potel-base    #4300      +/-   ##
==============================================
+ Coverage       83.55%   83.57%   +0.02%     
==============================================
  Files             144      144              
  Lines           14613    14613              
  Branches         2324     2324              
==============================================
+ Hits            12210    12213       +3     
+ Misses           1686     1684       -2     
+ Partials          717      716       -1
Files with missing lines Coverage Δ
sentry_sdk/integrations/logging.py 86.98% <100.00%> (+0.68%) ⬆️

... and 3 files with indirect coverage changes

@antonpirker antonpirker added Breaking change needs to go out in a major SDK 3.0 labels Apr 15, 2025
@antonpirker antonpirker marked this pull request as ready for review April 15, 2025 12:25
@antonpirker antonpirker requested a review from a team as a code owner April 15, 2025 12:25
szokeasaurusrex
szokeasaurusrex approved these changes Apr 15, 2025
View reviewed changes
Copy link
Member
@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Before merging, please change the commit title to make it clear that this change relates to logging, e.g.: feat(logging): Do not send logging events by default

@antonpirker antonpirker changed the title Do not send events by default feat(logging): Do not capture errors from LoggingIntegration to Sentry by default Apr 15, 2025
@antonpirker antonpirker merged commit 1e69dab into potel-base Apr 15, 2025
126 checks passed
@antonpirker antonpirker deleted the antonpirker/logging-not-sending-events-by-default branch April 15, 2025 12:56
@antonpirker antonpirker mentioned this pull request Apr 15, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szokeasaurusrex szokeasaurusrex szokeasaurusrex approved these changes

@sentrivana sentrivana sentrivana approved these changes

Assignees
No one assigned
Labels
Breaking change needs to go out in a major SDK 3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antonpirker @szokeasaurusrex @sentrivana
0