8000 ref: Move span processor out of `integrations/opentelemetry/` by sentrivana · Pull Request #4259 · getsentry/sentry-python · GitHub
[go: up one dir, main page]
Skip to content

ref: Move span processor out of integrations/opentelemetry/ #4259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 10, 2025
Merged

ref: Move span processor out of integrations/opentelemetry/ #4259

merged 10 commits into from
Apr 10, 2025

Conversation

sentrivana
Copy link
Contributor
@sentrivana sentrivana commented Apr 9, 2025 •
edited
Loading

Moving stuff out of integrations/opentelemetry/ step by step since there is no OpenTelemetry integration anymore -- it's part of the core SDK.

This moves sentry_sdk/integrations/opentelemetry/span_processor.py -> sentry_sdk/opentelemetry/span_processor.py

Ref #3853

@sentrivana sentrivana changed the base branch from potel-base to ivana/move-sampler-from-integration April 9, 2025 11:15
@sentrivana sentrivana mentioned this pull request Apr 9, 2025
Closed
8 tasks
@codecov Codecov
Copy link
codecov bot commented Apr 9, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
20480 1 20479 4416
View the top 1 failed test(s) by shortest run time 
tests.test_basics test_classmethod_tracing
Stack Traces | 0.159s run time 
tests/test_basics.py:811: in test_classmethod_tracing
    assert fake_start_child.call_count == 1
E   AssertionError: assert 3 == 1
E    +  where 3 = <MagicMock name='mock.start_child' id='140335641854352'>.call_count

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@sentrivana sentrivana marked this pull request as ready for review April 9, 2025 11:23
@sentrivana sentrivana requested a review from a team as a code owner April 9, 2025 11:23
@sentrivana sentrivana requested review from a team and removed request for a team April 9, 2025 11:23
Base automatically changed from ivana/move-sampler-from-integration to potel-base April 10, 2025 10:02
szokeasaurusrex
szokeasaurusrex approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member
@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@szokeasaurusrex szokeasaurusrex mentioned this pull request Apr 10, 2025
Merged
@sentrivana @szokeasaurusrex
Update sentry_sdk/integrations/opentelemetry/integration.py
bf9f231 
Co-authored-by: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
@sentrivana sentrivana merged commit 6af99bd into potel-base Apr 10, 2025
114 of 115 checks passed
@sentrivana sentrivana deleted the ivana/potel/move-span-processor-out-of-integration branch April 10, 2025 14:10
@sentrivana sentrivana mentioned this pull request Apr 10, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szokeasaurusrex szokeasaurusrex szokeasaurusrex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sentrivana @szokeasaurusrex
0