8000 feat(logs): Add server.address to logs by AbhiPrasad · Pull Request #4257 · getsentry/sentry-python · GitHub
[go: up one dir, main page]
Skip to content

feat(logs): Add server.address to logs #4257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 9, 2025
Merged

feat(logs): Add server.address to logs #4257

merged 2 commits into from
Apr 9, 2025

Conversation

AbhiPrasad
Copy link
Member

Docs: https://develop-docs-git-abhi-logs-sdk-developer-documentation.sentry.dev/sdk/telemetry/logs/#default-attributes

[BACKEND SDKS ONLY] server.address: The address of the server that sent the log. Equivalent to server_name we attach to errors and transactions.

server.address convention docs: https://getsentry.github.io/sentry-conventions/generated/attributes/server.html#serveraddress

resolves https://linear.app/getsentry/issue/LOGS-33

@AbhiPrasad AbhiPrasad self-assigned this Apr 9, 2025
@AbhiPrasad AbhiPrasad requested a review from a team as a code owner April 9, 2025 08:44
@AbhiPrasad AbhiPrasad requested a review from colin-sentry April 9, 2025 08:44
@codecov Codecov
Copy link
codecov bot commented Apr 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.57%. Comparing base (6a1364d) to head (24fc4ad).
Report is 2 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/client.py 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4257      +/-   ##
==========================================
+ Coverage   79.50%   79.57%   +0.06%     
==========================================
  Files         142      142              
  Lines       15898    15903       +5     
  Branches     2721     2723       +2     
==========================================
+ Hits        12640    12655      +15     
+ Misses       2391     2382       -9     
+ Partials      867      866       -1
Files with missing lines Coverage Δ
sentry_sdk/client.py 79.17% <66.66%> (+0.12%) ⬆️

... and 6 files with indirect coverage changes

@AbhiPrasad AbhiPrasad requested a review from sentrivana April 9, 2025 11:32
szokeasaurusrex
szokeasaurusrex approved these changes Apr 9, 2025
View reviewed changes
Copy link
Member
@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@AbhiPrasad AbhiPrasad merged commit acf508c into master Apr 9, 2025
137 of 138 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-server-address-in-logs branch April 9, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szokeasaurusrex szokeasaurusrex szokeasaurusrex approved these changes

@colin-sentry colin-sentry Awaiting requested review from colin-sentry

@sentrivana sentrivana Awaiting requested review from sentrivana

Assignees

@AbhiPrasad AbhiPrasad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AbhiPrasad @szokeasaurusrex
0